You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/26 19:39:36 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7606: KWF TsBuffer.h

SolidWallOfCode commented on a change in pull request #7606:
URL: https://github.com/apache/trafficserver/pull/7606#discussion_r602545941



##########
File path: proxy/ControlBase.cc
##########
@@ -411,7 +410,7 @@ struct TextMod : public ControlBase::Modifier {
 TextMod::TextMod() : text() {}
 TextMod::~TextMod()
 {
-  free(text.data());

Review comment:
       I dislike `const_cast`. In this case would a `char const*` work as well? Another alternative would be `MemSpan<char>` which provides a `view` method to extract a view when needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org