You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2022/12/01 07:58:10 UTC
[GitHub] [ambari] timyuer opened a new pull request, #3590: AMBARI-25789: Support BIGTOP-3.2.0 stack upgrade
timyuer opened a new pull request, #3590:
URL: https://github.com/apache/ambari/pull/3590
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
Tested successful upgrade in express.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] timyuer commented on pull request #3590: AMBARI-25789: Support BIGTOP-3.2.0 stack upgrade
Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #3590:
URL: https://github.com/apache/ambari/pull/3590#issuecomment-1333354299
Depends on https://github.com/apache/bigtop/pull/1058.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] timyuer commented on a diff in pull request #3590: AMBARI-25789: Support BIGTOP-3.2.0 stack upgrade
Posted by GitBox <gi...@apache.org>.
timyuer commented on code in PR #3590:
URL: https://github.com/apache/ambari/pull/3590#discussion_r1042101305
##########
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java:
##########
@@ -78,18 +78,23 @@ public UpgradeCheckResult perform(UpgradeCheckRequest request) throws AmbariExce
final StackId targetStackId = new StackId(repositoryVersion.getStackId());
- if (!repositoryVersion.getVersion().matches("^\\d+(\\.\\d+)*\\-\\d+$")) {
- String message = MessageFormat.format(
- "The Repository Version {0} for Stack {1} must contain a \"-\" followed by a build number. "
- + "Make sure that another registered repository does not have the same repo URL or "
- + "shares the same build number. Next, try reinstalling the Repository Version.",
- repositoryVersion.getVersion(), targetStackId.getStackVersion());
-
- result.getFailedOn().add("Repository Version " + repositoryVersion.getVersion());
- result.setStatus(UpgradeCheckStatus.FAIL);
- result.setFailReason(message);
- return result;
- }
+ /**
+ * Because the version for BigTop is BIGTOP-3.2.0,
+ * But the version for HDP is HDP-x.x.x.x-x,
+ * So to be compatible with both HDP and BIGTOP, comment out this.
+ */
+ // if (!repositoryVersion.getVersion().matches("^\\d+(\\.\\d+)*\\-\\d+$")) {
+ // String message = MessageFormat.format(
+ // "The Repository Version {0} for Stack {1} must contain a \"-\" followed by a build number. "
+ // + "Make sure that another registered repository does not have the same repo URL or "
+ // + "shares the same build number. Next, try reinstalling the Repository Version.",
+ // repositoryVersion.getVersion(), targetStackId.getStackVersion());
+
+ // result.getFailedOn().add("Repository Version " + repositoryVersion.getVersion());
+ // result.setStatus(UpgradeCheckStatus.FAIL);
+ // result.setFailReason(message);
+ // return result;
+ // }
Review Comment:
Update as comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 merged pull request #3590: AMBARI-25789: Add stack version suffix for BIGTOP packages
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #3590:
URL: https://github.com/apache/ambari/pull/3590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on a diff in pull request #3590: AMBARI-25789: Support BIGTOP-3.2.0 stack upgrade
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #3590:
URL: https://github.com/apache/ambari/pull/3590#discussion_r1041728772
##########
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java:
##########
@@ -78,18 +78,23 @@ public UpgradeCheckResult perform(UpgradeCheckRequest request) throws AmbariExce
final StackId targetStackId = new StackId(repositoryVersion.getStackId());
- if (!repositoryVersion.getVersion().matches("^\\d+(\\.\\d+)*\\-\\d+$")) {
- String message = MessageFormat.format(
- "The Repository Version {0} for Stack {1} must contain a \"-\" followed by a build number. "
- + "Make sure that another registered repository does not have the same repo URL or "
- + "shares the same build number. Next, try reinstalling the Repository Version.",
- repositoryVersion.getVersion(), targetStackId.getStackVersion());
-
- result.getFailedOn().add("Repository Version " + repositoryVersion.getVersion());
- result.setStatus(UpgradeCheckStatus.FAIL);
- result.setFailReason(message);
- return result;
- }
+ /**
+ * Because the version for BigTop is BIGTOP-3.2.0,
+ * But the version for HDP is HDP-x.x.x.x-x,
+ * So to be compatible with both HDP and BIGTOP, comment out this.
+ */
+ // if (!repositoryVersion.getVersion().matches("^\\d+(\\.\\d+)*\\-\\d+$")) {
+ // String message = MessageFormat.format(
+ // "The Repository Version {0} for Stack {1} must contain a \"-\" followed by a build number. "
+ // + "Make sure that another registered repository does not have the same repo URL or "
+ // + "shares the same build number. Next, try reinstalling the Repository Version.",
+ // repositoryVersion.getVersion(), targetStackId.getStackVersion());
+
+ // result.getFailedOn().add("Repository Version " + repositoryVersion.getVersion());
+ // result.setStatus(UpgradeCheckStatus.FAIL);
+ // result.setFailReason(message);
+ // return result;
+ // }
Review Comment:
We can just delete the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org