You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by gn...@apache.org on 2017/09/15 09:48:11 UTC
[3/3] karaf git commit: Optimize using Map#computeIfAbstent
Optimize using Map#computeIfAbstent
Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/15c578e8
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/15c578e8
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/15c578e8
Branch: refs/heads/karaf-4.1.x
Commit: 15c578e88b39ad170720a9cd4bf53a8ffe8e1ff3
Parents: d842a37
Author: Guillaume Nodet <gn...@gmail.com>
Authored: Fri Sep 15 08:01:41 2017 +0200
Committer: Guillaume Nodet <gn...@gmail.com>
Committed: Fri Sep 15 11:47:34 2017 +0200
----------------------------------------------------------------------
.../features/internal/service/FeaturesServiceImpl.java | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/karaf/blob/15c578e8/features/core/src/main/java/org/apache/karaf/features/internal/service/FeaturesServiceImpl.java
----------------------------------------------------------------------
diff --git a/features/core/src/main/java/org/apache/karaf/features/internal/service/FeaturesServiceImpl.java b/features/core/src/main/java/org/apache/karaf/features/internal/service/FeaturesServiceImpl.java
index 357d57f..507f2aa 100644
--- a/features/core/src/main/java/org/apache/karaf/features/internal/service/FeaturesServiceImpl.java
+++ b/features/core/src/main/java/org/apache/karaf/features/internal/service/FeaturesServiceImpl.java
@@ -782,13 +782,8 @@ public class FeaturesServiceImpl implements FeaturesService, Deployer.DeployCall
// * then load all features
for (Repository repo : repos) {
for (Feature f : repo.getFeatures()) {
- if (map.get(f.getName()) == null) {
- Map<String, Feature> versionMap = new HashMap<>();
- versionMap.put(f.getVersion(), f);
- map.put(f.getName(), versionMap);
- } else {
- map.get(f.getName()).put(f.getVersion(), f);
- }
+ Map<String, Feature> versionMap = map.computeIfAbsent(f.getName(), key -> new HashMap<>());
+ versionMap.put(f.getVersion(), f);
}
}
synchronized (lock) {