You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2024/02/20 18:21:12 UTC

Re: [PR] chore(tests): Remove ineffectual login [superset]

john-bodley commented on code in PR #27149:
URL: https://github.com/apache/superset/pull/27149#discussion_r1496300058


##########
tests/integration_tests/access_tests.py:
##########
@@ -103,11 +103,7 @@ def tearDownClass(cls):
             db.session.delete(security_manager.find_role(SCHEMA_ACCESS_ROLE))
             db.session.commit()
 
-    def setUp(self):

Review Comment:
   My hope was to use a new fixture `auth_as_admin` (which would leverage the `test_client` fixture), however mixing some facets of `pytest` and `unittest` don't work. As a follow up we should remove all `unittest` logic and purely use `pytest` constructs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org