You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/09 01:29:42 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #209:
SUBMARINE-410. Supplement submarine artifactId in pom.xml
liuxunorg opened a new pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml
URL: https://github.com/apache/submarine/pull/209
### What is this PR for?
At present, the artifactId of some submarine modules does not contain submarine, resulting in the compiled jar file without the submarine prefix.
### What type of PR is it?
[Bug Fix | Improvement | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-410
### How should this be tested?
* https://travis-ci.org/liuxunorg/submarine
### Screenshots (if appropriate)
```
find ./lib -name "*0.4.0*.jar"
./lib/submarine-commons-metastore-0.4.0-SNAPSHOT-shade.jar
./lib/submarine-server-rpc-0.4.0-SNAPSHOT.jar
./lib/submarine-commons-cluster-0.4.0-SNAPSHOT-shade.jar
./lib/submarine-commons-rpc-0.4.0-SNAPSHOT.jar
./lib/submarine-server-api-0.4.0-SNAPSHOT.jar
./lib/submarine-commons-cluster-0.4.0-SNAPSHOT.jar
./lib/submarine-submitter-yarn-0.4.0-SNAPSHOT.jar
./lib/submarine-commons-utils-0.4.0-SNAPSHOT.jar
./lib/submarine-commons-metastore-0.4.0-SNAPSHOT.jar
./lib/submarine-commons-runtime-0.4.0-SNAPSHOT.jar
./lib/submarine-server-core-0.4.0-SNAPSHOT.jar
./lib/submitter/k8s/submarine-server-api-0.4.0-SNAPSHOT.jar
./lib/submitter/k8s/submarine-commons-utils-0.4.0-SNAPSHOT.jar
./lib/submitter/k8s/submarine-submitter-k8s-0.4.0-SNAPSHOT.jar
./lib/submitter/yarn/submarine-submitter-yarn-0.4.0-SNAPSHOT-shade.jar
./lib/submarine-client-0.4.0-SNAPSHOT.jar
```
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #209:
SUBMARINE-410. Supplement submarine artifactId in pom.xml
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml
URL: https://github.com/apache/submarine/pull/209#discussion_r389456330
##########
File path: submarine-server/server-rpc/src/main/java/org/apache/submarine/server/rpc/SubmarineRpcServer.java
##########
@@ -225,7 +224,7 @@ private ApplicationIdProto checkFeature(ParametersHolderProto request) {
protected ApplicationId run(ClientContext clientContext, Parameter parameter)
throws IOException, YarnException, SubmarineException {
- // TODO replaced with JobManager
+ // TODO(who) replaced with JobManager
Review comment:
beacuse todo must specify who to complete.
https://github.com/apache/submarine/blob/master/dev-support/maven-config/checkstyle.xml#L42
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #209:
SUBMARINE-410. Supplement submarine artifactId in pom.xml
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml
URL: https://github.com/apache/submarine/pull/209#discussion_r389449630
##########
File path: submarine-server/server-rpc/src/main/java/org/apache/submarine/server/rpc/SubmarineRpcServer.java
##########
@@ -225,7 +224,7 @@ private ApplicationIdProto checkFeature(ParametersHolderProto request) {
protected ApplicationId run(ClientContext clientContext, Parameter parameter)
throws IOException, YarnException, SubmarineException {
- // TODO replaced with JobManager
+ // TODO(who) replaced with JobManager
Review comment:
What do you mean by adding who? Is this generated by code formatter automatically?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #209: SUBMARINE-410.
Supplement submarine artifactId in pom.xml
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml
URL: https://github.com/apache/submarine/pull/209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org