You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/07 16:16:31 UTC

[GitHub] [beam] AnandInguva commented on a diff in pull request #22164: Modify RunInference to return PipelineResult for the benchmark tests

AnandInguva commented on code in PR #22164:
URL: https://github.com/apache/beam/pull/22164#discussion_r916058751


##########
sdks/python/apache_beam/examples/inference/pytorch_language_modeling.py:
##########
@@ -131,6 +133,7 @@ def parse_known_args(argv):
   """Parses args for the workflow."""
   parser = argparse.ArgumentParser()
   parser.add_argument(
+      '--input_file',
       '--input',

Review Comment:
   These are used in this pattern https://github.com/apache/beam/blob/ca653ed0ef7b504536f4bb7968d3d8dd5d4ccf0d/sdks/python/apache_beam/testing/benchmarks/inference/pytorch_benchmarks.py#L55
   
   I forgot that these are getting skipped. I will test them locally. thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org