[GitHub] [drill] paul-rogers commented on a diff in pull request #2511: DRILL-8174: Convert Avro format to EVF2

[GitBox <gi...@apache.org>]

paul-rogers commented on code in PR #2511:
URL: https://github.com/apache/drill/pull/2511#discussion_r841304669


##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroBatchReader.java:
##########
@@ -38,59 +45,52 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.IOException;
-import java.security.PrivilegedExceptionAction;
-
-public class AvroBatchReader implements ManagedReader<FileScanFramework.FileSchemaNegotiator> {
+public class AvroBatchReader implements ManagedReader {
   private static final Logger logger = LoggerFactory.getLogger(AvroBatchReader.class);
 
-  private Path filePath;
-  private long endPosition;
+  private final Path filePath;
+  private final long endPosition;
   private DataFileReader<GenericRecord> reader;

Review Comment:
   Can `reader` be final as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org