You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/06/16 20:36:03 UTC

Re: [PR] 8.x Register CriteriaTypeCheckingExtension and cover createCriteria().{} closures [grails-core]

codeconsole commented on PR #15720:
URL: https://github.com/apache/grails-core/pull/15720#issuecomment-4723373536

   Wired `StaticCompiledCriteriaSpec` into `HibernateSuite` and `Hibernate5Suite` (`34854cbfc1`). The spec had been added to the TCK but wasn't in any `@SelectClasses` suite, so it never ran against a GORM implementation. It now executes against both Hibernate 7 and Hibernate 5 — 9 tests each, asserting real query results — covering both dispatch paths the extension produces: static delegate dispatch (`eq`/`like`/`or`/`order`) and the dynamic fallback (projections, `maxResults`, `count` chained on `createCriteria()`). A regression in either ORM now fails CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org