You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Samer-Melhem-FOO (via GitHub)" <gi...@apache.org> on 2026/07/27 12:33:40 UTC
[PR] FINERACT-2715: Mark Activation Date as required in Client Entity import template [fineract]
Samer-Melhem-FOO opened a new pull request, #6189:
URL: https://github.com/apache/fineract/pull/6189
## Description
The Client Entity bulk import template did not visually indicate that "Activation Date" is a required column. `ClientEntityImportHandler` requires a valid Activation Date whenever the "Active" column is set to `true`, so imports failed on rows left blank without any indication from the template that the field was mandatory.
This changes the column header in `ClientEntityWorkbookPopulator` from `"Activation Date "` to `"Activation Date* "`, consistent with how other conditionally-required columns (e.g. `"Active*"`) are marked on the same sheet.
## JIRA
https://issues.apache.org/jira/browse/FINERACT-2715
## Test plan
- [x] `./gradlew :fineract-provider:compileJava` passes
- [x] Verified no existing test asserts the previous header string (integration test `ClientEntityWorkbookPopulatorTest` does not hardcode it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2715: Mark Activation Date as required in Client Entity import template [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #6189:
URL: https://github.com/apache/fineract/pull/6189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2715: Mark Activation Date as required in Client Entity import template [fineract]
Posted by "Samer-Melhem-FOO (via GitHub)" <gi...@apache.org>.
Samer-Melhem-FOO commented on PR #6189:
URL: https://github.com/apache/fineract/pull/6189#issuecomment-5092283672
The only failing check here is `run-e2e-tests / E2E Tests (Shard 4 of 20)`. Looking at the log, it fails at the `jibDockerBuild` step before any tests run, with:
```
I/O error for image [registry-1.docker.io/azul/zulu-openjdk-alpine]:
java.net.SocketException
Network is unreachable
```
This looks like a transient Docker Hub registry connectivity issue on the runner, unrelated to this PR's change (a single header-label fix in `ClientEntityWorkbookPopulator`). All other 19/20 E2E shards, all 15/15 DB-matrix shards (MariaDB/MySQL/PostgreSQL), and every other check (checkstyle, spotless, spotbugs, etc.) passed.
Could a maintainer re-run the failed job? I don't have the permissions to trigger a re-run myself. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org