You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2020/01/29 01:34:15 UTC
[incubator-datasketches-cpp] branch rm_unnecessary_methods created
(now af693b7)
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a change to branch rm_unnecessary_methods
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git.
at af693b7 removed trivial copy constructors
This branch includes the following new commits:
new af693b7 removed trivial copy constructors
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 01/01: removed trivial copy
constructors
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a commit to branch rm_unnecessary_methods
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit af693b77518a50654d6bda788c1f5ace99059db2
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Tue Jan 28 17:33:59 2020 -0800
removed trivial copy constructors
---
fi/include/reverse_purge_hash_map.hpp | 1 -
kll/include/kll_sketch.hpp | 1 -
kll/include/kll_sketch_impl.hpp | 5 -----
3 files changed, 7 deletions(-)
diff --git a/fi/include/reverse_purge_hash_map.hpp b/fi/include/reverse_purge_hash_map.hpp
index 9fa1425..6176500 100644
--- a/fi/include/reverse_purge_hash_map.hpp
+++ b/fi/include/reverse_purge_hash_map.hpp
@@ -89,7 +89,6 @@ template<typename T, typename H, typename E, typename A>
class reverse_purge_hash_map<T, H, E, A>::const_iterator: public std::iterator<std::input_iterator_tag, T> {
public:
friend class reverse_purge_hash_map<T, H, E, A>;
- const_iterator(const const_iterator& other) : map(other.map), index(other.index), count(other.count), stride(other.stride) {}
const_iterator& operator++() {
++count;
if (count < map->num_active) {
diff --git a/kll/include/kll_sketch.hpp b/kll/include/kll_sketch.hpp
index 141f55c..28f5fcb 100644
--- a/kll/include/kll_sketch.hpp
+++ b/kll/include/kll_sketch.hpp
@@ -331,7 +331,6 @@ template<typename T, typename C, typename S, typename A>
class kll_sketch<T, C, S, A>::const_iterator: public std::iterator<std::input_iterator_tag, T> {
public:
friend class kll_sketch<T, C, S, A>;
- const_iterator(const const_iterator& other);
const_iterator& operator++();
const_iterator& operator++(int);
bool operator==(const const_iterator& other) const;
diff --git a/kll/include/kll_sketch_impl.hpp b/kll/include/kll_sketch_impl.hpp
index dcd2453..efd76e2 100644
--- a/kll/include/kll_sketch_impl.hpp
+++ b/kll/include/kll_sketch_impl.hpp
@@ -932,11 +932,6 @@ items(items), levels(levels), num_levels(num_levels), index(levels == nullptr ?
{}
template<typename T, typename C, typename S, typename A>
-kll_sketch<T, C, S, A>::const_iterator::const_iterator(const const_iterator& other):
-items(other.items), levels(other.levels), num_levels(other.num_levels), index(other.index), level(other.level), weight(other.weight)
-{}
-
-template<typename T, typename C, typename S, typename A>
typename kll_sketch<T, C, S, A>::const_iterator& kll_sketch<T, C, S, A>::const_iterator::operator++() {
++index;
if (index == levels[level + 1]) { // go to the next non-empty level
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org