You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/07/22 15:52:42 UTC
Review Request 12812: CLOUDSTACK-3610: Fix regression test
"test_accounts.TestUserLogin"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12812/
-----------------------------------------------------------
Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam.
Bugs: CLOUDSTACK-3610
Repository: cloudstack-git
Description
-------
Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors.
Diffs
-----
test/integration/component/test_accounts.py 65c0c6f
tools/marvin/marvin/integration/lib/base.py bc8c603
Diff: https://reviews.apache.org/r/12812/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 12812: CLOUDSTACK-3610: Fix regression test
"test_accounts.TestUserLogin"
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12812/#review23639
-----------------------------------------------------------
Commit 18fbbcfc5a3bea98576cc819a37b00b227616cae in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=18fbbcf ]
CLOUDSTACK-3610: Fix regression test "test_accounts.TestUserLogin"
Now password is sent as clear text as per CLOUDSTACK-1734
So changed marvin to handle this. Plus domainid was not
passed in the testcase and marvin used "domainid" instead of
"domainId" as a parameter. Fixed these two errors.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit dba09791fc99c342974d8ca1c69609c04f1a5512)
- ASF Subversion and Git Services
On July 22, 2013, 1:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12812/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3610
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 65c0c6f
> tools/marvin/marvin/integration/lib/base.py bc8c603
>
> Diff: https://reviews.apache.org/r/12812/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12812: CLOUDSTACK-3610: Fix regression test
"test_accounts.TestUserLogin"
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12812/#review23630
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On July 22, 2013, 1:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12812/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3610
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 65c0c6f
> tools/marvin/marvin/integration/lib/base.py bc8c603
>
> Diff: https://reviews.apache.org/r/12812/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12812: CLOUDSTACK-3610: Fix regression test
"test_accounts.TestUserLogin"
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12812/#review23631
-----------------------------------------------------------
Review 12812 PASSED the build test
The url of build cloudstack-master-with-patch #12 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/12/
- Jenkins Cloudstack.org
On July 22, 2013, 1:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12812/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3610
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 65c0c6f
> tools/marvin/marvin/integration/lib/base.py bc8c603
>
> Diff: https://reviews.apache.org/r/12812/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12812: CLOUDSTACK-3610: Fix regression test
"test_accounts.TestUserLogin"
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12812/#review23641
-----------------------------------------------------------
Commit b44c6208506791c4af6363f7471b1c367d37cc1a in branch refs/heads/4.2 from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b44c620 ]
CLOUDSTACK-3610: Fix regression test "test_accounts.TestUserLogin"
Now password is sent as clear text as per CLOUDSTACK-1734
So changed marvin to handle this. Plus domainid was not
passed in the testcase and marvin used "domainid" instead of
"domainId" as a parameter. Fixed these two errors.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 22, 2013, 1:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12812/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 1:52 p.m.)
>
>
> Review request for cloudstack, Parth Jagirdar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3610
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Now password is sent as clear text as per CLOUDSTACK-1734. So changed marvin to handle this. Plus domainid was not passed in the testcase and marvin used "domainid" instead of "domainId" as a parameter. Fixed these two errors.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 65c0c6f
> tools/marvin/marvin/integration/lib/base.py bc8c603
>
> Diff: https://reviews.apache.org/r/12812/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>