[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline

[GitBox <gi...@apache.org>]

imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545614856



##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
 	ServiceProtocol string                 `json:"service_protocol,omitempty"`
 	Labels          map[string]string      `json:"labels,omitempty"`
 	EnableWebsocket bool                   `json:"enable_websocket,omitempty"`
+	Status          uint8                  `json:"status"`

Review comment:
       @liuxiran @nic-chen 
   I guess this line need using a pointer to `Status` type, and should be changed to
   ```suggestion
   	Status          *Status                  `json:"status"`
   ```
   
   With `uint8`, we can not distinguish whether the `status` field is unset or set to `0`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org