You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/14 16:56:58 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
v01d opened a new pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785
## Summary
The "export" keyword can be used in make to have all child `$(MAKE)` calls have the variable defined without having to manually pass it via command line. Since `TOPDIR` is needed everywhere, this removes the need to pass it around all the time.
## Impact
Build
## Testing
Built locally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-692726438
> I suspect this change will add more breakage to the Windows native build. 'export' is a GNU/Bash command and Bash is not used (the shell is CMD.com in the Windows native build).
>
> In the Windows native build, we do use GNUWin32 which provides a small subset of GNU commands, but I can find no reference to the 'export' command being supported.
But "export" is a Makefile keyword, it should not depend on bash: https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-692532748
BTW, @v01d should we expose APPDIR/TOPDIR for Makefile in apps folder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-692844998
> BTW, @v01d should we expose APPDIR/TOPDIR for Makefile in apps folder?
I have this ready, once this is merged I can submit it so that CI runs against this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-692728291
> But "export" is a Makefile keyword, it should not depend on bash: https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html
Then I retract my question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-692717497
I suspect this change will add more breakage to the Windows native build. 'export' is a GNU/Bash command and Bash is not used (the shell is CMD.com in the Windows native build).
In the Windows native build, we do use GNUWin32 which provides a small subset of GNU commands, but I can find no reference to the 'export' command being supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1785: use "export" to expose TOPDIR to all child make instead of passing it around every time
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1785:
URL: https://github.com/apache/incubator-nuttx/pull/1785#issuecomment-693158138
LGTM, let's merge it to unblock other upcoming PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org