You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 18:51:51 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4238: Don't use __attribute__ in source code directly

gustavonihei commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-889379511


   > The change is intentional, you can review it separately here:
   > [14582e1](https://github.com/apache/incubator-nuttx/commit/14582e1fc4afb08039e248a0ea0cfb8e1751d70d)
   
   The change is not related to this PR, so I think it should be left out.
   This function is probably not built by any CI configuration, because this `USB_DmaDesc` symbol seems to come from the vendor's BSP. Another evidence is the `epph` on the below line, which contains a typo and should be `epphy`.
   
   If we simply remove that single line it will probably make someone's life more difficult to track an eventual bug on this driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org