[GitHub] [druid] vogievetsky opened a new pull request, #13136: Web console: better spec conversion with issues

[GitBox <gi...@apache.org>]

vogievetsky opened a new pull request, #13136:
URL: https://github.com/apache/druid/pull/13136

   This PR adds the concept of issue comments: a comment like `--:ISSUE: this is an issue` that can be added in SQL which will be rendered in red and will prevent the SQL from running. These comments are then used by the spec-to-SQL converter to indicate that something could not be converted. The spec converter will also (purposefully) generate invalid SQL to force the user to take action and not just click `Run`.
   
   <img width="996" alt="image" src="https://user-images.githubusercontent.com/177816/191653579-fc975925-c62d-4955-968a-7fb777f929ad.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #13136: Web console: better spec conversion with issues

[GitBox <gi...@apache.org>]

gianm merged PR #13136:
URL: https://github.com/apache/druid/pull/13136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org