You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/14 05:07:15 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5448: [Vmware] Fix for ovf templates with prefix
nvazquez opened a new pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448
### Description
This PR adds a "ovf" prefix check on Vmware template OVF files.
Fixes: #5415
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919448520
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919821146
Can you add to the `How hs this been tested` chapter in the description, @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918806725
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919422927
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919231144
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918806338
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919180617
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919446150
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919424278
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918843532
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919118016
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919448029
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919967766
LGTM, cheers @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918826064
Hi @nvazquez do we know what causes the prefix to be added? Is this due to exporting ovf template from vmware, virtualbox or something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919225586
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-920547034
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919527674
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919230219
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919527166
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919472628
<b>Trillian Build Failed (tid-2045)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919118459
@rhtyd yes this prefix can be added when exporting a template from Vmware
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-921044934
<b>Trillian test result (tid-2076)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5448-t2076-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-920546653
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919179770
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5448:
URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-919940089
@DaanHoogland I have updated the PR description, please check. Manual tests performed by @NuxRo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org