You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2023/03/06 23:50:25 UTC

[GitHub] [trafficserver] bneradt commented on a diff in pull request #9491: Adds a new percentage option, cleans up pressure calculations

bneradt commented on code in PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#discussion_r1127155975


##########
doc/admin-guide/plugins/rate_limit.en.rst:
##########
@@ -161,10 +161,10 @@ The following options are available:
 .. option:: --iprep_buckets
 
    The number of LRU buckets to use for the IP reputation. A good number here
-   is 10, but can be configured. The reason for the different buckets is to
-   account for a pseudo-sorted list of IPs on the frequency seen. Too few buckets
-   will not be enough to keep such a sorting, rendering the algorithm useless. To
-   function in our setup, the number of buckets must be less than ``100``.
+   is `10`, which is the default, but can be configured. The reason for the different

Review Comment:
   Need two ticks around 10. Otherwise this is italicized instead of a code space string.
   
   There's a few examples of this in this patch, but just marking this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org