You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/11 21:30:07 UTC

[GitHub] [beam] lostluck commented on a diff in pull request #17337: [BEAM-14287] Clean up staticcheck warnings in graph/coder

lostluck commented on code in PR #17337:
URL: https://github.com/apache/beam/pull/17337#discussion_r847751351


##########
sdks/go/pkg/beam/core/graph/coder/row_test.go:
##########
@@ -228,7 +228,6 @@ type UserType4 struct {
 type unexportedUserType struct {
 	A int
 	B string
-	c int32

Review Comment:
   Hmmm this field is supposed to be test significant (in that it won't get encoded.) But I guess the test for that never got added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org