You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Armin Le Grand <Ar...@me.com> on 2012/11/28 10:42:21 UTC
Error in Gallery
Hi List,
with the current build there is an error in the gallery (in the windows
version, others not checked). When you open the gallery (in any
application) there is a first theme called '<resource ID 6015 not
found>' which is wrong. That theme is the normally hidden theme
'htmlexpo' (the gallery has various hidden themes which are internally
used as access to graphics, e.g. in this case for html exports).
I checked back to revision 1401221, (what I currently have on old stuff
on my HD), it's already broken there.
Does someone have an idea what change may have done this? It must have
to do with ressource changes somehow...
Sincerely,
Armin
--
ALG
Re: Error in Gallery
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi *
On Wed, Nov 28, 2012 at 03:21:58PM +0100, Regina Henschel wrote:
> >You are observing that this hidden theme is visible in the gallery in a
> >pro build.
> >This is not good - this needs also to be solved.
> >In our released versions - AOO 3.4 and AOO 3.4.1 - this gallery theme is
> >not visible. At least what I have observed in my environment.
>
> "Visible" means, that I have set the environment to show hidden
> gallery themes. And yes then I see it, in AOO3.4.1 and in a buildbot
> build as well.
It seems Regina knows the hidden secret:
export GALLERY_SHOW_HIDDEN_THEMES
See GalleryBrowser1::ImplInsertThemeEntry
This will show hidden themes in a pro-build. In a non-pro build this
theme is displayed for the reasons I tried to explain in my previous
mail.
> This icon set can be chosen in File > Wizard > Web page. If I choose
> it, I do not see any icon in the result. But I'm not familiar with
> that Wizard and might miss something.
Interesting finding! For what I could understand, it seems that Ocke
thought the theme wasn't used anywhere but he forgot to remove it.
The bug is notorious in a non-pro build, that's why everybody working on
the source code should build non-pro builds :)
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Error in Gallery
Posted by Regina Henschel <rb...@t-online.de>.
Hi Oliver,
Oliver-Rainer Wittmann schrieb:
> Hi,
>
> On 28.11.2012 14:05, Regina Henschel wrote:
>> Hi Ariel,
>>
>> Ariel Constenla-Haile schrieb:
>>> On Wed, Nov 28, 2012 at 01:20:16PM +0100, Regina Henschel wrote:
>>>> Hi Armin,
>>>>
>>>>
>>>> Armin Le Grand schrieb:
>>>>> Hi List,
>>>>>
>>>>> with the current build there is an error in the gallery (in the
>>>>> windows
>>>>> version, others not checked). When you open the gallery (in any
>>>>> application) there is a first theme called '<resource ID 6015 not
>>>>> found>' which is wrong. That theme is the normally hidden theme
>>>>> 'htmlexpo' (the gallery has various hidden themes which are internally
>>>>> used as access to graphics, e.g. in this case for html exports).
>>>>> I checked back to revision 1401221, (what I currently have on old
>>>>> stuff
>>>>> on my HD), it's already broken there.
>>>>> Does someone have an idea what change may have done this? It must have
>>>>> to do with ressource changes somehow...
>>>>
>>>> No idea, but here is, what I see: I get this error in my non-pro
>>>> build of r1403730 and r1381583 but not in the buildbot build. I
>>>> don't know the version of the buildbot build, the About box
>>>> says,"AOO350m1(Build:9611) - Rev. 1412119 Rev.1411094"
>>>>
>>>> In a non-pro build of r1381583 I see an error, which might be related:
>>>> Error:
>>>> file:///E:/SoftwareArchiv/OOoDownloads/AOO%202012-09-git%20r1381583/program/../Basis/program/resource/galen-US.res
>>>>
>>>>
>>>> Class: String, Id: 6015. Cannot load resource!
>>>> Resource Stack
>>>> Class: DockingWindow, Id: 10365
>>>>
>>>> But I don't know, how to look up, which string is that with Id "6015".
>>>
>>> You won't find it, it was removed:
>>>
>>> http://hg.services.openoffice.org/OOO340/rev/902597eed541
>>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
>>>
>>>
>>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
>>>
>>>
>>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
>>>
>>
>> I have seen in the meantime from your link, that is was removed in
>> galtheme.src.
>> But now I wonder, from where it comes into the UI of the gallery
>> window? I still
>> see "private://gallery/hidden/HtmlExportButtons" listed in the theme
>> list in a
>> normal build.
>>
>
> You are observing that this hidden theme is visible in the gallery in a
> pro build.
> This is not good - this needs also to be solved.
> In our released versions - AOO 3.4 and AOO 3.4.1 - this gallery theme is
> not visible. At least what I have observed in my environment.
"Visible" means, that I have set the environment to show hidden gallery
themes. And yes then I see it, in AOO3.4.1 and in a buildbot build as well.
>
> Internally, a gallery theme consists of three binary files which are
> found in Basis/share/gallery/ of the installation and
> [UserInstallionDir]/share/gallery/
> One of these file - the .thm one - contains also the name of the gallery.
> This hidden theme consists of the following files:
> sg25.thm, sg25.sdg and sg25.sdv
The file sg25.thm exists and contains
private://gallery/hidden/HtmlExportButtons as first entry. The
associated folder htmlexpo indeed exists in Basis/share/gallery/ too.
This icon set can be chosen in File > Wizard > Web page. If I choose it,
I do not see any icon in the result. But I'm not familiar with that
Wizard and might miss something.
Kind regards
Regina
Re: Error in Gallery
Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.
Hi,
On 28.11.2012 14:05, Regina Henschel wrote:
> Hi Ariel,
>
> Ariel Constenla-Haile schrieb:
>> On Wed, Nov 28, 2012 at 01:20:16PM +0100, Regina Henschel wrote:
>>> Hi Armin,
>>>
>>>
>>> Armin Le Grand schrieb:
>>>> Hi List,
>>>>
>>>> with the current build there is an error in the gallery (in the windows
>>>> version, others not checked). When you open the gallery (in any
>>>> application) there is a first theme called '<resource ID 6015 not
>>>> found>' which is wrong. That theme is the normally hidden theme
>>>> 'htmlexpo' (the gallery has various hidden themes which are internally
>>>> used as access to graphics, e.g. in this case for html exports).
>>>> I checked back to revision 1401221, (what I currently have on old stuff
>>>> on my HD), it's already broken there.
>>>> Does someone have an idea what change may have done this? It must have
>>>> to do with ressource changes somehow...
>>>
>>> No idea, but here is, what I see: I get this error in my non-pro
>>> build of r1403730 and r1381583 but not in the buildbot build. I
>>> don't know the version of the buildbot build, the About box
>>> says,"AOO350m1(Build:9611) - Rev. 1412119 Rev.1411094"
>>>
>>> In a non-pro build of r1381583 I see an error, which might be related:
>>> Error:
>>> file:///E:/SoftwareArchiv/OOoDownloads/AOO%202012-09-git%20r1381583/program/../Basis/program/resource/galen-US.res
>>>
>>> Class: String, Id: 6015. Cannot load resource!
>>> Resource Stack
>>> Class: DockingWindow, Id: 10365
>>>
>>> But I don't know, how to look up, which string is that with Id "6015".
>>
>> You won't find it, it was removed:
>>
>> http://hg.services.openoffice.org/OOO340/rev/902597eed541
>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
>>
>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
>>
>> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
>
> I have seen in the meantime from your link, that is was removed in galtheme.src.
> But now I wonder, from where it comes into the UI of the gallery window? I still
> see "private://gallery/hidden/HtmlExportButtons" listed in the theme list in a
> normal build.
>
You are observing that this hidden theme is visible in the gallery in a pro build.
This is not good - this needs also to be solved.
In our released versions - AOO 3.4 and AOO 3.4.1 - this gallery theme is not
visible. At least what I have observed in my environment.
Internally, a gallery theme consists of three binary files which are found in
Basis/share/gallery/ of the installation and [UserInstallionDir]/share/gallery/
One of these file - the .thm one - contains also the name of the gallery.
This hidden theme consists of the following files:
sg25.thm, sg25.sdg and sg25.sdv
Best regards, Oliver.
Re: Error in Gallery
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi Regina,
On Wed, Nov 28, 2012 at 02:05:34PM +0100, Regina Henschel wrote:
> >>But I don't know, how to look up, which string is that with Id "6015".
> >
> >You won't find it, it was removed:
> >
> >http://hg.services.openoffice.org/OOO340/rev/902597eed541
> >http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
> >http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
> >http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
>
> I have seen in the meantime from your link, that is was removed in
> galtheme.src. But now I wonder, from where it comes into the UI of
> the gallery window? I still see
> "private://gallery/hidden/HtmlExportButtons" listed in the theme
> list in a normal build.
I recall I researched this when I opened the bug report, but somehow it
went out of my radar ;)
IIRC the private URL is stored in the theme itself as its name, try
[ariel@localhost ~]$ cd /opt/openoffice.org/basis3.4/share/gallery/
[ariel@localhost gallery]$ hexdump -C -n 48 sg25.thm
00000000 04 00 2a 00 70 72 69 76 61 74 65 3a 2f 2f 67 61 |..*.private://ga|
00000010 6c 6c 65 72 79 2f 68 69 64 64 65 6e 2f 48 74 6d |llery/hidden/Htm|
00000020 6c 45 78 70 6f 72 74 42 75 74 74 6f 6e 73 30 00 |lExportButtons0.|
00000030
The underlying reason why this gallery is displayed on a non-pro build
is that the gallery theme is not considered as hidden.
A hidden theme is one whose name begins with "private://gallery/hidden/"
see GalleryThemeEntry
sal_Bool IsHidden() const { return aName.SearchAscii( "private://gallery/hidden/" ) == 0; }
Though the name is really stored inside the theme file, it is replaced
in the GalleryThemeEntry constructor:
* the constructor gets the theme name as read from the theme file
* it tries to get the localized theme name from the resource first
* UniString::UniString( const ResId& rResId ) instead of creating
an empty string when the respective resource is missing (default
behaviour on a pro build), it returns a string with the error, see
http://opengrok.adfinis-sygroup.org/source/xref/aoo-trunk/main/tools/source/string/strucvt.cxx#195
* this string has a length > 0, then it replaces the original string as
read from the theme file
* this way, IsHidden will return false: the theme is not hidden as its
name does not start with private://gallery/hidden anymore
* then the theme is displayed in the UI on a non-pro build
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Error in Gallery
Posted by Regina Henschel <rb...@t-online.de>.
Hi Ariel,
Ariel Constenla-Haile schrieb:
> On Wed, Nov 28, 2012 at 01:20:16PM +0100, Regina Henschel wrote:
>> Hi Armin,
>>
>>
>> Armin Le Grand schrieb:
>>> Hi List,
>>>
>>> with the current build there is an error in the gallery (in the windows
>>> version, others not checked). When you open the gallery (in any
>>> application) there is a first theme called '<resource ID 6015 not
>>> found>' which is wrong. That theme is the normally hidden theme
>>> 'htmlexpo' (the gallery has various hidden themes which are internally
>>> used as access to graphics, e.g. in this case for html exports).
>>> I checked back to revision 1401221, (what I currently have on old stuff
>>> on my HD), it's already broken there.
>>> Does someone have an idea what change may have done this? It must have
>>> to do with ressource changes somehow...
>>
>> No idea, but here is, what I see: I get this error in my non-pro
>> build of r1403730 and r1381583 but not in the buildbot build. I
>> don't know the version of the buildbot build, the About box
>> says,"AOO350m1(Build:9611) - Rev. 1412119 Rev.1411094"
>>
>> In a non-pro build of r1381583 I see an error, which might be related:
>> Error: file:///E:/SoftwareArchiv/OOoDownloads/AOO%202012-09-git%20r1381583/program/../Basis/program/resource/galen-US.res
>> Class: String, Id: 6015. Cannot load resource!
>> Resource Stack
>> Class: DockingWindow, Id: 10365
>>
>> But I don't know, how to look up, which string is that with Id "6015".
>
> You won't find it, it was removed:
>
> http://hg.services.openoffice.org/OOO340/rev/902597eed541
> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
I have seen in the meantime from your link, that is was removed in
galtheme.src. But now I wonder, from where it comes into the UI of the
gallery window? I still see "private://gallery/hidden/HtmlExportButtons"
listed in the theme list in a normal build.
Kind regards
Regina
Re: Error in Gallery
Posted by Ariel Constenla-Haile <ar...@apache.org>.
On Wed, Nov 28, 2012 at 01:20:16PM +0100, Regina Henschel wrote:
> Hi Armin,
>
>
> Armin Le Grand schrieb:
> >Hi List,
> >
> >with the current build there is an error in the gallery (in the windows
> >version, others not checked). When you open the gallery (in any
> >application) there is a first theme called '<resource ID 6015 not
> >found>' which is wrong. That theme is the normally hidden theme
> >'htmlexpo' (the gallery has various hidden themes which are internally
> >used as access to graphics, e.g. in this case for html exports).
> >I checked back to revision 1401221, (what I currently have on old stuff
> >on my HD), it's already broken there.
> >Does someone have an idea what change may have done this? It must have
> >to do with ressource changes somehow...
>
> No idea, but here is, what I see: I get this error in my non-pro
> build of r1403730 and r1381583 but not in the buildbot build. I
> don't know the version of the buildbot build, the About box
> says,"AOO350m1(Build:9611) - Rev. 1412119 Rev.1411094"
>
> In a non-pro build of r1381583 I see an error, which might be related:
> Error: file:///E:/SoftwareArchiv/OOoDownloads/AOO%202012-09-git%20r1381583/program/../Basis/program/resource/galen-US.res
> Class: String, Id: 6015. Cannot load resource!
> Resource Stack
> Class: DockingWindow, Id: 10365
>
> But I don't know, how to look up, which string is that with Id "6015".
You won't find it, it was removed:
http://hg.services.openoffice.org/OOO340/rev/902597eed541
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Error in Gallery
Posted by Regina Henschel <rb...@t-online.de>.
Hi Armin,
Armin Le Grand schrieb:
> Hi List,
>
> with the current build there is an error in the gallery (in the windows
> version, others not checked). When you open the gallery (in any
> application) there is a first theme called '<resource ID 6015 not
> found>' which is wrong. That theme is the normally hidden theme
> 'htmlexpo' (the gallery has various hidden themes which are internally
> used as access to graphics, e.g. in this case for html exports).
> I checked back to revision 1401221, (what I currently have on old stuff
> on my HD), it's already broken there.
> Does someone have an idea what change may have done this? It must have
> to do with ressource changes somehow...
No idea, but here is, what I see: I get this error in my non-pro build
of r1403730 and r1381583 but not in the buildbot build. I don't know the
version of the buildbot build, the About box says,"AOO350m1(Build:9611)
- Rev. 1412119 Rev.1411094"
In a non-pro build of r1381583 I see an error, which might be related:
Error:
file:///E:/SoftwareArchiv/OOoDownloads/AOO%202012-09-git%20r1381583/program/../Basis/program/resource/galen-US.res
Class: String, Id: 6015. Cannot load resource!
Resource Stack
Class: DockingWindow, Id: 10365
But I don't know, how to look up, which string is that with Id "6015".
The theme itself is named
private://gallery/hidden/HtmlExportButtons
I see that name in the UI in the gallery window, but I cannot find
"HtmlExportButtons" in the source. In svx/source/gallery2/galtheme.src I
find only the other hidden theme names "imgppt", "usersounds", "fontwork".
Kind regards
Regina
Re: Error in Gallery
Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.
Hi,
On 28.11.2012 13:06, Ariel Constenla-Haile wrote:
> Hi Armin,
>
> On Wed, Nov 28, 2012 at 10:42:21AM +0100, Armin Le Grand wrote:
>> Hi List,
>>
>> with the current build there is an error in the gallery (in the
>> windows version, others not checked). When you open the gallery (in
>> any application) there is a first theme called '<resource ID 6015
>> not found>' which is wrong. That theme is the normally hidden theme
>> 'htmlexpo' (the gallery has various hidden themes which are
>> internally used as access to graphics, e.g. in this case for html
>> exports).
>> I checked back to revision 1401221, (what I currently have on old
>> stuff on my HD), it's already broken there.
>> Does someone have an idea what change may have done this? It must
>> have to do with ressource changes somehow...
>
> see https://issues.apache.org/ooo/show_bug.cgi?id=118845
>
> That was http://hg.services.openoffice.org/OOO340/rev/902597eed541
> 276753:902597eed541 07-Feb-2011 Ocke.Janssen@oracle.com
> impress210: #i105310# set tooltip for items and some refactoring
>
> It removed all uses of that gallery, including the ID
> http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
>
> but if forgot to remove the gallery itself. IMO the fix is to remove the
> theme, or reintroduce it properly (but if it unused, this makes no
> sense).
>
>
Ariel, you are superior. Thanks for saving my day (and I think Armin's, too).
Thanks for the pointer to the already existing issue - shame on me that I did
not had a look into our Bugzilla issue database.
Thus, we need to check, if this hidden theme is used or not.
For the HTML export of presentation documents this hidden theme is not used -
here the resources from /main/sd/res/buttons/ are used.
But, I do not know, if this hidden theme is somewhere else used.
Armin just told me that he will "solve" this issue during his improvement work
on the gallery.
Best regards, Oliver.
Re: Error in Gallery
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi Armin,
On Wed, Nov 28, 2012 at 10:42:21AM +0100, Armin Le Grand wrote:
> Hi List,
>
> with the current build there is an error in the gallery (in the
> windows version, others not checked). When you open the gallery (in
> any application) there is a first theme called '<resource ID 6015
> not found>' which is wrong. That theme is the normally hidden theme
> 'htmlexpo' (the gallery has various hidden themes which are
> internally used as access to graphics, e.g. in this case for html
> exports).
> I checked back to revision 1401221, (what I currently have on old
> stuff on my HD), it's already broken there.
> Does someone have an idea what change may have done this? It must
> have to do with ressource changes somehow...
see https://issues.apache.org/ooo/show_bug.cgi?id=118845
That was http://hg.services.openoffice.org/OOO340/rev/902597eed541
276753:902597eed541 07-Feb-2011 Ocke.Janssen@oracle.com
impress210: #i105310# set tooltip for items and some refactoring
It removed all uses of that gallery, including the ID
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
but if forgot to remove the gallery itself. IMO the fix is to remove the
theme, or reintroduce it properly (but if it unused, this makes no
sense).
Regards
--
Ariel Constenla-Haile
La Plata, Argentina