You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/23 03:00:27 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
zuzana-vej opened a new issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404
### Description:
When editing the value of a simple filter in explore box, backspaces and spaces are broken. It seems like they are not being entered into the filter value text box but are instead being entered into the filter column drop down. The space problem also occurs when editing custom SQL, which majorly breaks custom sql filters. The only workaround to type a space is to type the value/custom sql elsewhere and paste it into the desired textbox.
How often can this be reproduced?
100%
### Steps to Reproduce:
1. Create a table chart
2. Click FILTERS drop down and select a column
3. Type a space and observe that the space is entered into the filters drop down instead of the value text box
4. Type a backspace and observe that the filter modal closes
### Result:
After typing space: Space does not appear in filter value text box
After typing backspace: Modal closes
### Expected Result:
After typing space: Space appears in filter value text box
After typing backspace: The character before the cursor disappears.
### Screenshots
### Environment
(please complete the following information):
- superset version: `master`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-720488316
@junlincc It's been fixed by https://github.com/apache/incubator-superset/pull/11428, I think we can close this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-716422650
I'll check it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714883482
> @junlincc This could be caused by the same PR as the other cosmetic issues on chart explore: #11394 #11379
just tested.agreed. 👌 https://github.com/apache/incubator-superset/issues/11379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-720596057
Yes it's fixed. thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714883482
> @junlincc This could be caused by the same PR as the other cosmetic issues on chart explore: #11394 #11379
just tested.agreed. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714877133
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.95. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714883482
> @junlincc This could be caused by the same PR as the other cosmetic issues on chart explore: #11394 #11379
just tested.agreed. 👌 https://github.com/apache/incubator-superset/pull/11163/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714904910
@kgabryje ^^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404#issuecomment-714877515
@junlincc This could be caused by the same PR as the other cosmetic issues on chart explore: https://github.com/apache/incubator-superset/issues/11394 https://github.com/apache/incubator-superset/issues/11379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej closed issue #11404: Backspaces and spaces do not work when editing simple filter value in explore chart
Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #11404:
URL: https://github.com/apache/incubator-superset/issues/11404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org