You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/09/18 09:41:34 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #42976: [SPARK-45056][CONNECT][TESTS] Change the tests related to Python in `SparkConnectSessionHodlerSuite` to assume shouldTestPandasUDFs

LuciferYang commented on code in PR #42976:
URL: https://github.com/apache/spark/pull/42976#discussion_r1328476440


##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectSessionHodlerSuite.scala:
##########
@@ -170,7 +170,7 @@ class SparkConnectSessionHolderSuite extends SharedSparkSession {
 
   test("python foreachBatch process: process terminates after query is stopped") {
     // scalastyle:off assume
-    assume(IntegratedUDFTestUtils.shouldTestPythonUDFs)
+    assume(IntegratedUDFTestUtils.shouldTestPandasUDFs)

Review Comment:
   cc @HyukjinKwon FYI
   



##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectSessionHodlerSuite.scala:
##########
@@ -170,7 +170,7 @@ class SparkConnectSessionHolderSuite extends SharedSparkSession {
 
   test("python foreachBatch process: process terminates after query is stopped") {
     // scalastyle:off assume
-    assume(IntegratedUDFTestUtils.shouldTestPythonUDFs)
+    assume(IntegratedUDFTestUtils.shouldTestPandasUDFs)

Review Comment:
   I will install Python dependencies for Maven's daily testing in another PR
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org