[GitHub] [incubator-datasketches-java] leerho commented on a change in pull request #324: Refactor theta tuple

[GitBox <gi...@apache.org>]

leerho commented on a change in pull request #324:
URL: https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r452532816



##########
File path: src/main/java/org/apache/datasketches/BoundsOnRatiosInSampledSets.java
##########
@@ -82,6 +82,28 @@ public static double getEstimateOfBoverA(final long a, final long b) {
     return (double) b / a;
   }
 
+  /**
+   * Return the estimate of A. See class javadoc.
+   * @param a See class javadoc
+   * @param f the inclusion probability used to produce the set with size <i>a</i>.
+   * @return the approximate lower bound
+   */
+  public static double getEstimateOfA(final long a, final double f) {
+    checkInputs(a, 1, f);
+    return a / f;
+  }
+
+  /**
+   * Return the estimate of B. See class javadoc.
+   * @param b See class javadoc
+   * @param f the inclusion probability used to produce the set with size <i>a</i>.

Review comment:
       You are correct! Excellent catch!
   
   WRT Question above: The Serialization Version only relates to the storage layout and independent of the code release version.  And, yes, it our intention to retain "binary compatibility" across languages and backward compatibility across time.  We are already binary compatible with sketch binaries produced 8 years ago.   This means we can read the old sketch binaries, but when serializing, we serialize to the latest SerVer=3.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org