[GitHub] [spark] xuanyuanking commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap
URL: https://github.com/apache/spark/pull/24062#discussion_r267400640
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceOptionsSuite.scala
 ##########
 @@ -104,4 +104,9 @@ class DataSourceOptionsSuite extends SparkFunSuite {
 
     assert(options.paths().toSeq == Seq("c", "d\"e"))
   }
+
+  test("asMap") {
+    val map = new DataSourceOptions(Map("fooBar" -> "x").asJava).asMap
 
 Review comment:
   After #24025, below test passed.
   ```
   val map = new CaseInsensitiveStringMap(Map("fooBar" -> "x").asJava).asCaseSensitiveMap()
   assert(map.get("fooBar") == "x")
   ```
   #24094 also add `asCaseSensitiveMap` in CaseInsensitiveStringMap for Hadoop Configurations. So this PR is no more needed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org