You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/10/22 14:51:18 UTC

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

timtebeek commented on code in PR #545:
URL: https://github.com/apache/wicket/pull/545#discussion_r1002499905


##########
wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java:
##########
@@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception
 
 		FieldBeansCollector fieldBeansCollector = new FieldBeansCollector(resolvableType);
 
-		assertTrue(fieldBeansCollector.getFieldType() == FieldType.LIST);
+		assertEquals(fieldBeansCollector.getFieldType(), FieldType.LIST);

Review Comment:
   Logged as a [possible improvement here](https://github.com/openrewrite/rewrite-testing-frameworks/issues/275). Once that's automated we can again apply it here, to also migrate any other imperfectly placed argument orders.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org