You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kdelay (via GitHub)" <gi...@apache.org> on 2026/09/24 00:32:45 UTC
[PR] fix: implement makeAggregateCombiner for momentSketch (druid)
kdelay opened a new pull request, #20413:
URL: https://github.com/apache/druid/pull/20413
Fixes #13220.
### Description
`MomentSketchAggregatorFactory` had no `makeAggregateCombiner()`, so rollup ingestion that persists more than one intermediate index failed in `IndexMergerV9` with the UOE from the issue. The existing test never merged: the data rolls up to 9 rows and `maxRowCount` is 10.
The combiner follows `TDigestSketchAggregatorFactory`: `reset` starts a new sketch with the factory's `k` and `compress`, and `fold` merges into it, never into the selector's object.
Tests: an ingestion test with `maxRowCount` 3, and a unit test for the combiner. Both fail with the UOE without the fix. The module tests (29), checkstyle and forbiddenapis pass.
#### Release note
Fixed rollup ingestion with `momentSketch` metrics failing during index merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: implement makeAggregateCombiner for momentSketch (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 merged PR #20413:
URL: https://github.com/apache/druid/pull/20413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: implement makeAggregateCombiner for momentSketch (druid)
Posted by "kdelay (via GitHub)" <gi...@apache.org>.
kdelay commented on PR #20413:
URL: https://github.com/apache/druid/pull/20413#issuecomment-5814170009
Thanks for the review. The one red check (QTest 1/4) failed during dependency resolution: repo.maven.apache.org returned HTTP 429 Too Many Requests before any test ran (job 107442169669). This PR only touches the momentsketch extension. Could someone with access re-run that job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org