You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Balázs Németh (Jira)" <ji...@apache.org> on 2022/05/27 01:40:00 UTC
[jira] [Comment Edited] (BEAM-14522) ProtoSchemaTranslator creates NOT NULL beam schema fields even for optional proto fields
[ https://issues.apache.org/jira/browse/BEAM-14522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542739#comment-17542739 ]
Balázs Németh edited comment on BEAM-14522 at 5/27/22 1:39 AM:
---------------------------------------------------------------
Nvm, my bad, replaced by https://issues.apache.org/jira/browse/BEAM-14525
was (Author: bnemeth):
Nvm, replaced by https://issues.apache.org/jira/browse/BEAM-14525
> ProtoSchemaTranslator creates NOT NULL beam schema fields even for optional proto fields
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-14522
> URL: https://issues.apache.org/jira/browse/BEAM-14522
> Project: Beam
> Issue Type: Bug
> Components: extensions-java-protobuf
> Reporter: Balázs Németh
> Priority: P2
>
> ProtoSchemaTranslator is capable of creating Beam schemas (org.apache.beam.sdk.schemas.Schema) from proto classes. The problem is that the code that transforms the non-null org.apache.beam.sdk.schemas.Schema.FieldType into a nullable one is at a wrong place. Instead of doing it for every type for every field that is optional at the proto class after the switch-case it is actually inside the switch-case and only does it for MESSAGE and GROUP types.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)