[GitHub] [drill] paul-rogers commented on a change in pull request #1807: DRILL-7293: Convert the regex ("log") plugin to use EVF

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1807: DRILL-7293: Convert the regex ("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r293633490
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/log/TestLogReader.java
 ##########
 @@ -389,4 +416,56 @@ public void testRawUMNoSchema() throws RpcException {
 
     RowSetUtilities.verify(expected, results);
   }
+
+  @Test
+  public void testProvidedSchema() throws Exception {
 
 Review comment:
   Short answer: it does not seem to work. I tried this in the past and found that table functions take only simple values (numbers, strings), not lists. Since this plugin uses a list, I never could figure out how to use it with table functions. In particular, how would the table function know how to create the instance of `LogFormatField` within the list? Am I missing something?
   
   This plugin, in particular, would very much benefit from the use of a table function so that the user does not have to define a new plugin config for each new file type.
   
   If there is a way to make this work, we can add the test and describe the answer in the README file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services