You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2017/01/10 15:29:07 UTC
[GitHub] flink pull request #3088: [FLINK-5407] Fix savepoints for iterative jobs
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3088
[FLINK-5407] Fix savepoints for iterative jobs
This PR fixes savepoints for iterative jobs. Savepoints failed with NPE because the code assumed that operators in an operator chain are never null. For iterative jobs, this can happen.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink NPE-Iterative-Snapshot
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3088
----
commit 984d596c063b5082520d8d58baa6b7361b1e9921
Author: Stefan Richter <s....@data-artisans.com>
Date: 2017-01-05T13:28:50Z
[FLINK-5407] Handle snapshoting null-operator in chain
commit c96fe7ba35764b4f9e05ed61199b2027981daa54
Author: Stefan Richter <s....@data-artisans.com>
Date: 2017-01-10T15:08:06Z
[FLINK-5407] IT case for savepoint with iterative job
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3088
Changes look very good! I fixed the formatting of the newly added methods in `TestingCluster` to conform to Scala coding guidelines.
I rebased on master, will wait for Travis to give the green light and then merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/3088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3088
cc @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3088
Thanks for reviewing and merging @aljoscha !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by senorcarbone <gi...@git.apache.org>.
Github user senorcarbone commented on the issue:
https://github.com/apache/flink/pull/3088
Hey! In this upcoming [PR ](https://github.com/apache/flink/pull/1668) there is a custom operator responsible for the logging at the iteration head. Hope this does not break your tests in case they assume a null op.
Also, in case any of you is familiar with asynchronous checkpoints with ListState, could you check my last question in the same PR? thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3088: [FLINK-5407] Fix savepoints for iterative jobs
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3088
Merged, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---