You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by PRASHANT GOLASH via Review Board <no...@reviews.apache.org> on 2017/07/18 22:16:05 UTC
Review Request 60950: [HIVE-17117] - Meta listeners are not notified
of meta-conf cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
Diff: https://reviews.apache.org/r/60950/diff/1/
Testing
-------
Added unit test cases for the affected codepath.
Thanks,
PRASHANT GOLASH
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 283 (patched)
> > <https://reviews.apache.org/r/60950/diff/2/?file=1778809#file1778809line283>
> >
> > is this really needed ? see comment below.
For same reasons as mentioned below.
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 393 (patched)
> > <https://reviews.apache.org/r/60950/diff/2/?file=1778809#file1778809line393>
> >
> > If you make this static, I think you can do away with the need of creating a thread local HMSHandler (threadLocalHMSHandler), i.e. You already have a thread local map (threadLocalModifiedMetaConfKeys), so you should not need to reference it using another thread local (threadLocalHMSHandler).
HMSHandler object is required to be passed in ConfigChangeEvent constructor in notifyMetaListeners. DeleteContext is invoked on TServerEventHandler object where I don't have any access to HMSHandler object, hence I saved the invoking HMSHandler on threadLocal.
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 396 (patched)
> > <https://reviews.apache.org/r/60950/diff/2/?file=1778809#file1778809line396>
> >
> > Please rename m to something more clear (in this context), like modifiedConfig.
Done.
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 403 (patched)
> > <https://reviews.apache.org/r/60950/diff/2/?file=1778809#file1778809line403>
> >
> > nit: just use threadLocalConf.get() directly, get rid of the conf above
Done.
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 412 (patched)
> > <https://reviews.apache.org/r/60950/diff/2/?file=1778809#file1778809line412>
> >
> > For clarity, move this to finally() inside cleanupRawStore(), so that all thread local cleanup is captured in one place as HMSHandler.threadLocalModifiedMetaConfKeys.remove().
Done.
- PRASHANT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180897
-----------------------------------------------------------
On July 19, 2017, 7:40 a.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 7:40 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/3/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180897
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 283 (patched)
<https://reviews.apache.org/r/60950/#comment256218>
is this really needed ? see comment below.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 393 (patched)
<https://reviews.apache.org/r/60950/#comment256214>
If you make this static, I think you can do away with the need of creating a thread local HMSHandler (threadLocalHMSHandler), i.e. You already have a thread local map (threadLocalModifiedMetaConfKeys), so you should not need to reference it using another thread local (threadLocalHMSHandler).
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 396 (patched)
<https://reviews.apache.org/r/60950/#comment256215>
Please rename m to something more clear (in this context), like modifiedConfig.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 403 (patched)
<https://reviews.apache.org/r/60950/#comment256216>
nit: just use threadLocalConf.get() directly, get rid of the conf above
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 412 (patched)
<https://reviews.apache.org/r/60950/#comment256217>
For clarity, move this to finally() inside cleanupRawStore(), so that all thread local cleanup is captured in one place as HMSHandler.threadLocalModifiedMetaConfKeys.remove().
- Mohit Sabharwal
On July 18, 2017, 10:58 p.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 10:58 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/2/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
> On July 19, 2017, 10:12 p.m., Chao Sun wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 283 (patched)
> > <https://reviews.apache.org/r/60950/diff/4/?file=1780072#file1780072line283>
> >
> > These do not seem unnecessary. Maybe replace with:
> > ```
> > private static final ThreadLocal<HMSHandler> threadLocalHMSHandler = new ThreadLocal<>();
> > ```
> > ?
Done.
> On July 19, 2017, 10:12 p.m., Chao Sun wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 382 (patched)
> > <https://reviews.apache.org/r/60950/diff/4/?file=1780072#file1780072line382>
> >
> > Maybe we can move this line before 375?
Though the comment mentioned that all fields are final, yet i see that base class ListenerEvent has some set methods for e.g setEnvironmentContext. Though same object has been passed to transactionalListeners, I am not 100% sure of the behavior with respect to normal listeners. Would prefer to keep this same.
- PRASHANT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180981
-----------------------------------------------------------
On July 19, 2017, 8:49 p.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 8:49 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/4/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by Chao Sun <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180981
-----------------------------------------------------------
Looks good to me. Just a few minor comments.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 283 (patched)
<https://reviews.apache.org/r/60950/#comment256367>
These do not seem unnecessary. Maybe replace with:
```
private static final ThreadLocal<HMSHandler> threadLocalHMSHandler = new ThreadLocal<>();
```
?
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 382 (patched)
<https://reviews.apache.org/r/60950/#comment256372>
Maybe we can move this line before 375?
- Chao Sun
On July 19, 2017, 8:49 p.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 8:49 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/4/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review181012
-----------------------------------------------------------
Ship it!
Ship It!
- Mohit Sabharwal
On July 20, 2017, 12:39 a.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 12:39 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/5/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------
(Updated July 20, 2017, 12:39 a.m.)
Review request for hive.
Changes
-------
Code review comments.
Repository: hive-git
Description
-------
Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
Diff: https://reviews.apache.org/r/60950/diff/5/
Changes: https://reviews.apache.org/r/60950/diff/4-5/
Testing
-------
Added unit test cases for the affected codepath.
Thanks,
PRASHANT GOLASH
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------
(Updated July 19, 2017, 8:49 p.m.)
Review request for hive.
Changes
-------
Addressed code review comments.
Repository: hive-git
Description
-------
Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
Diff: https://reviews.apache.org/r/60950/diff/4/
Changes: https://reviews.apache.org/r/60950/diff/3-4/
Testing
-------
Added unit test cases for the affected codepath.
Thanks,
PRASHANT GOLASH
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> > Lines 471 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779140#file1779140line473>
> >
> > Don't think you need this sleep since you are explicitly calling HiveMetaStoreClient#close
It looks close -> thrift#shutdown is async call (inherited in ThriftHiveMetastore via FacebookService.iface), hence I guess sleep would be necessary.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> > Lines 500 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779140#file1779140line502>
> >
> > closing explicitly, so sleep should not be needed.
Same as above.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> > Lines 515 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779140#file1779140line517>
> >
> > same here.
Same as above.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 298 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779141#file1779141line298>
> >
> > You can set this to null here. And explicitly initialize the thread local in setMetaConf. That way, you don't need to create HashMap for every thread if setMetaConf is never called (common case).
Done.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 395 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779141#file1779141line395>
> >
> > null check needed if you init this to null based on feedback comment.
Done. Did a smaller change to handle unexpected null case of threadLocalConf on the similar lines.
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 7598 (patched)
> > <https://reviews.apache.org/r/60950/diff/3/?file=1779141#file1779141line7611>
> >
> > Once you initialize threadLocalModifiedConfig to null, check if threadLocalModifiedConfig is non null before calling notifyMetaListenersOnShutDown
I am already checking for handler (which gets initialized in along with threadLocalModifiedConfig in setMetaConf), so not adding additional check.
- PRASHANT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180914
-----------------------------------------------------------
On July 19, 2017, 8:49 p.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 8:49 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/4/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review180914
-----------------------------------------------------------
Thanks, couple more items.
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
Lines 471 (patched)
<https://reviews.apache.org/r/60950/#comment256257>
Don't think you need this sleep since you are explicitly calling HiveMetaStoreClient#close
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
Lines 500 (patched)
<https://reviews.apache.org/r/60950/#comment256258>
closing explicitly, so sleep should not be needed.
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
Lines 515 (patched)
<https://reviews.apache.org/r/60950/#comment256262>
same here.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 298 (patched)
<https://reviews.apache.org/r/60950/#comment256259>
You can set this to null here. And explicitly initialize the thread local in setMetaConf. That way, you don't need to create HashMap for every thread if setMetaConf is never called (common case).
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 395 (patched)
<https://reviews.apache.org/r/60950/#comment256261>
null check needed if you init this to null based on feedback comment.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 7598 (patched)
<https://reviews.apache.org/r/60950/#comment256260>
Once you initialize threadLocalModifiedConfig to null, check if threadLocalModifiedConfig is non null before calling notifyMetaListenersOnShutDown
- Mohit Sabharwal
On July 19, 2017, 7:40 a.m., PRASHANT GOLASH wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60950/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 7:40 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
>
>
> Diff: https://reviews.apache.org/r/60950/diff/3/
>
>
> Testing
> -------
>
> Added unit test cases for the affected codepath.
>
>
> Thanks,
>
> PRASHANT GOLASH
>
>
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------
(Updated July 19, 2017, 7:40 a.m.)
Review request for hive.
Changes
-------
Addressed code review comments of [~mohitsabharwal]
Repository: hive-git
Description
-------
Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
Diff: https://reviews.apache.org/r/60950/diff/3/
Changes: https://reviews.apache.org/r/60950/diff/2-3/
Testing
-------
Added unit test cases for the affected codepath.
Thanks,
PRASHANT GOLASH
Re: Review Request 60950: [HIVE-17117] - Meta listeners are not
notified of meta-conf cleanup.
Posted by PRASHANT GOLASH via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/
-----------------------------------------------------------
(Updated July 18, 2017, 10:58 p.m.)
Review request for hive.
Changes
-------
Fixed an issue in one of the unit test case.
Repository: hive-git
Description
-------
Added the code to notify meta listeners during shutdown. Shutdown would eventually call cleanupRawStore (In both cases HMSHandler#close and TServerEventHandler#DeleteContext), so called the notification code in that function.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java fd4527e653
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930
Diff: https://reviews.apache.org/r/60950/diff/2/
Changes: https://reviews.apache.org/r/60950/diff/1-2/
Testing
-------
Added unit test cases for the affected codepath.
Thanks,
PRASHANT GOLASH