You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/09 21:55:50 UTC
[GitHub] [lucene-solr] zhaih opened a new pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
zhaih opened a new pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE-8574
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Upgrade HPPC to 0.8.2
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zhaih commented on pull request #1560: LUCENE-9391: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642835331
Do I need to squash the commits? Seems commits in Lucene are all squashed? Or it will be done automatically when merging somehow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #1560: LUCENE-9391: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zhaih commented on a change in pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
zhaih commented on a change in pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#discussion_r438569802
##########
File path: lucene/ivy-versions.properties
##########
@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6
/com.carrotsearch.thirdparty/simple-xml-safe = 2.7.1
-/com.carrotsearch/hppc = 0.8.1
+/com.carrotsearch/hppc = 0.8.2
Review comment:
I think so? In `facet`'s `ivy.xml` it use `rev="${/com.carrotsearch/hppc}"` which I believe is the variable here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zhaih commented on pull request #1560: LUCENE-9391: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642830815
> Hi Patrick,
> Thanks for your contribution 👍
> I found the JIRA-issue number of this PR is wrong.
> It should be changed from [LUCENE-8574] to [LUCENE-9391].
> https://issues.apache.org/jira/browse/LUCENE-9391
> Please check it.
Oh, thank you for figuring that out! Yeah I picked up a wrong one from my backlog... Thank you very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-641821902
Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and Lucene, I guess) and attribution to your name? Otherwise LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
mikemccand commented on a change in pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#discussion_r438144513
##########
File path: lucene/ivy-versions.properties
##########
@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6
/com.carrotsearch.thirdparty/simple-xml-safe = 2.7.1
-/com.carrotsearch/hppc = 0.8.1
+/com.carrotsearch/hppc = 0.8.2
Review comment:
Does this then mean that Lucene's `facet` module's usage of HPPC is upgraded too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] danmuzi commented on pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
danmuzi commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642827027
Hi Patrick,
Thanks for your contribution 👍
I found the JIRA-issue number of this PR is wrong.
It should be changed from [LUCENE-8574] to [LUCENE-9391].
https://issues.apache.org/jira/browse/LUCENE-9391
Please check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] danmuzi commented on pull request #1560: LUCENE-9391: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
danmuzi commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642844611
Please do the **"Squash and merge"** below.
Your sub commits will be combined automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zhaih commented on pull request #1560: LUCENE-8574: Upgrade HPPC to 0.8.2
Posted by GitBox <gi...@apache.org>.
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642435935
> Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and Lucene, I guess) and attribution to your name? Otherwise LGTM.
Thanks for reminding me that! Added!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org