You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "gabotechs (via GitHub)" <gi...@apache.org> on 2026/03/05 07:52:10 UTC

[PR] Wire up with_new_state with DataSource [datafusion]

gabotechs opened a new pull request, #20718:
URL: https://github.com/apache/datafusion/pull/20718

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   `ExecutionPlan::with_new_state()` allows devs to inject custom information in their nodes that they can use for tweaking their `ExecutionPlan` implementations.
   
   This mechanism does not work today if the `ExecutionPlan` is a `DataSourceExec`, as this one does not implement the `with_new_state()` method from `ExecutionPlan`.
   
   In order to let people use this also for their own `DataSource` implementations, this PR adds this method to it.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Propagates `with_new_state()` to the `DataSource` trait, so that custom `DataSourceExec` can also benefit from it.
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   As it's just method plumbing, my impression is that having a test for it is overkill.
   
   ## Are there any user-facing changes?
   
   Users can now implement their `with_new_state()` also in `DataSource`, not only in `ExecutionPlan`
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Wire up with_new_state with DataSource [datafusion]

Posted by "gabotechs (via GitHub)" <gi...@apache.org>.
gabotechs merged PR #20718:
URL: https://github.com/apache/datafusion/pull/20718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Wire up with_new_state with DataSource [datafusion]

Posted by "gabotechs (via GitHub)" <gi...@apache.org>.
gabotechs commented on PR #20718:
URL: https://github.com/apache/datafusion/pull/20718#issuecomment-4004487388

   It was shipped in https://github.com/apache/datafusion/pull/16469, there's a bit more context there.
   
   Internally, we do use it in leaf nodes that we are trying to move from plain `ExecutionPlan` into `DataSource` implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org