You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/09/10 23:51:03 UTC
[kudu-CR] move KUDU NO EXPORT attribute on methods
Hello Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11415
to review the following change.
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
move KUDU_NO_EXPORT attribute on methods
Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
---
M src/kudu/client/client.h
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11415/1
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
move KUDU_NO_EXPORT attribute on methods
The original location was ineffective due to a bug in older versions of
GCC, [1] appears to be the best tracking issue. Adding the annotation at
the end of the method signature silences the warnings on GCC 4.8, and
maintains symbol hiding as checked with nm.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30361
Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Reviewed-on: http://gerrit.cloudera.org:8080/11415
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client.h
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
Patch Set 2:
Interestingly this issue only cropped up with modify_external_catalogs, I believe because it's the only use of the annotation with a pointer return type. I moved all annotations to maintain consistency and make it more likely that a copy/paste of the annotation in the future will not be broken.
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 23:54:00 +0000
Gerrit-HasComments: No
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11415
to look at the new patch set (#4).
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
move KUDU_NO_EXPORT attribute on methods
The original location was ineffective due to a bug in older versions of
GCC, [1] appears to be the best tracking issue. Adding the annotation at
the end of the method signature silences the warnings on GCC 4.8, and
maintains symbol hiding as checked with nm.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30361
Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
---
M src/kudu/client/client.h
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11415/4
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
Patch Set 3: Code-Review+2
LINT failure is legit.
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 17:45:45 +0000
Gerrit-HasComments: No
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 22:10:07 +0000
Gerrit-HasComments: No
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 00:10:47 +0000
Gerrit-HasComments: No
[kudu-CR] move KUDU NO EXPORT attribute on methods
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11415
to look at the new patch set (#2).
Change subject: move KUDU_NO_EXPORT attribute on methods
......................................................................
move KUDU_NO_EXPORT attribute on methods
The original location was ineffective due to a bug in older versions of
GCC, [1] appears to be the best tracking issue. Adding the annotation at
the end of the method signature silences the warnings on GCC 4.8, and
maintains symbol hiding as checked with nm.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30361
Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
---
M src/kudu/client/client.h
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11415/2
--
To view, visit http://gerrit.cloudera.org:8080/11415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Gerrit-Change-Number: 11415
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins