[GitHub] [ozone] xBis7 commented on pull request #4574: HDDS-8428. Inconsistent Metrics units in CMSMetrics

["xBis7 (via GitHub)" <gi...@apache.org>]

xBis7 commented on PR #4574:
URL: https://github.com/apache/ozone/pull/4574#issuecomment-1512869558

   @xichen01 I think some test cases results would be useful to get an idea of the average numbers. That way, we can tell If we end up losing accuracy. If that's the case, I agree with @ChenSammi, why not keep everything as it is and modify the metric names? 
   
   ```diff
   - private @Metric MutableRate applyTransaction;
   + private @Metric MutableRate applyTransactionInMs;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org