You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/10 06:38:55 UTC

[GitHub] [tvm] FrozenGene commented on a change in pull request #6889: [TOPI] sparse_dense Op sparse_data input added

FrozenGene commented on a change in pull request #6889:
URL: https://github.com/apache/tvm/pull/6889#discussion_r539895683



##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -937,7 +937,15 @@ struct DenseAttrs : public tvm::AttrsNode<DenseAttrs> {
 
 /*! \brief Attributes for sparse_dense operator */
 struct SparseDenseAttrs : public tvm::AttrsNode<SparseDenseAttrs> {
-  TVM_DECLARE_ATTRS(SparseDenseAttrs, "relay.attrs.SparseDenseAttrs") {}
+  bool sparse_lhs;

Review comment:
       need we naming it with suffix `lhs`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org