You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/05 17:04:31 UTC
[GitHub] ivankelly opened a new pull request #1865: Ledger manager factories
initialized with max metadata version
ivankelly opened a new pull request #1865: Ledger manager factories initialized with max metadata version
URL: https://github.com/apache/bookkeeper/pull/1865
In dce4fd4 the max metadata format version was put in the
configuration which was then used to create ledger managers. This is
not safe though, as it there are multiple paths which through which
ledger manager factories are created and some may not see this
configuration modification. For example, on a new cluster where there
is no preexisting layout, the layout isn't written until after the
ledger manager factory has been created.
This patch changes LedgerManagerFactory#initialize to explicitly
require that the max ledger metadata format is specified in the call.
Master issue: #723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services