You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/07 18:52:22 UTC
[GitHub] [beam] lukecwik opened a new pull request, #24014: [#21250] Trivial removal of loop over something that always has one element
lukecwik opened a new pull request, #24014:
URL: https://github.com/apache/beam/pull/24014
Multiplexing was put into the PCollectionConsumerRegistry a long time ago and this seems to have been missed during that migration.
Benchmark results show that this is noise.
New code:
```
Result org.apache.beam.fn.harness.jmh.ProcessBundleBenchmark.testLargeBundle:
988.040 ±(99.9%) 36.859 ops/s [Average]
(min, avg, max) = (939.097, 988.040, 1031.625), stdev = 34.478
CI (99.9%): [951.181, 1024.899] (assumes normal distribution)
```
Old code:
```
Result "org.apache.beam.fn.harness.jmh.ProcessBundleBenchmark.testLargeBundle":
984.372 ±(99.9%) 11.445 ops/s [Average]
(min, avg, max) = (965.547, 984.372, 1000.351), stdev = 10.705
CI (99.9%): [972.928, 995.817] (assumes normal distribution)
```
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24014: [#21250] Trivial removal of loop over something that always has one element
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24014:
URL: https://github.com/apache/beam/pull/24014#issuecomment-1306046367
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #24014: [#21250] Trivial removal of loop over something that always has one element
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #24014:
URL: https://github.com/apache/beam/pull/24014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24014: [#21250] Trivial removal of loop over something that always has one element
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24014:
URL: https://github.com/apache/beam/pull/24014#issuecomment-1306111868
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #24014: [#21250] Trivial removal of loop over something that always has one element
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #24014:
URL: https://github.com/apache/beam/pull/24014#issuecomment-1306045348
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24014: [#21250] Trivial removal of loop over something that always has one element
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24014:
URL: https://github.com/apache/beam/pull/24014#issuecomment-1306092045
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org