[GitHub] [servicecomb-toolkit] MabinGo commented on a change in pull request #37: SCB-1493 Support generating SpringCloud project

[GitBox <gi...@apache.org>]

MabinGo commented on a change in pull request #37: SCB-1493 Support generating SpringCloud project
URL: https://github.com/apache/servicecomb-toolkit/pull/37#discussion_r340989258
 
 

 ##########
 File path: codegen/src/main/resources/ServiceComb/consumer/microservice.mustache
 ##########
 @@ -5,7 +5,7 @@ service_description:
 #The microservice name should be unique within an application.
 #The name can contain digits, uppercase and lowercase letters, hyphens(-), underscores(_), and periods(.); and can neither start nor end with punctuations.
 #The naming rule is as follows: ^[a-zA-Z0-9]+$|^[a-zA-Z0-9][a-zA-Z0-9_-.]*[a-zA-Z0-9]$.
-  name: {{microserviceName}}-consumer
+  name: {{serviceId}}
 
 Review comment:
   both of provider and consumer use the "serviceId" as value, it will generate the same service name while we 
    use ServiceType in all

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services