You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2018/11/05 19:08:06 UTC

[GitHub] zeppelin pull request #3218: [ZEPPELIN-3849] display note name correctly.

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/3218

    [ZEPPELIN-3849] display note name correctly.

    ### What is this PR for?
    Master branch displays note id instead of note name.
    I think it's side effect after change https://github.com/apache/zeppelin/pull/3163.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3849
    
    ### How should this be tested?
    See if note name is displayed instead of note id
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-3849

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3218
    
----
commit 3e91b990f213d0119692e8aa0e0c8050e393e8f2
Author: Lee moon soo <mo...@...>
Date:   2018-11-05T17:52:01Z

    display note name

----


---

[GitHub] zeppelin issue #3218: [ZEPPELIN-3849] display note name correctly.

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3218
  
    Thanks @felixcheung @zjffdu for review. Merge to master.


---

[GitHub] zeppelin pull request #3218: [ZEPPELIN-3849] display note name correctly.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3218


---

[GitHub] zeppelin issue #3218: [ZEPPELIN-3849] display note name correctly.

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3218
  
    Thanks @Leemoonsoo +1


---