[GitHub] [cloudstack] nvazquez commented on a change in pull request #5837: Faster SystemVM Template Builds

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5837:
URL: https://github.com/apache/cloudstack/pull/5837#discussion_r830031871



##########
File path: systemvm/image/scripts/install_systemvm_packages.sh
##########
@@ -96,10 +90,9 @@ function install_packages() {
   # Install docker and containerd for CKS
   curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
   apt-key fingerprint 0EBFCD88
-  add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/debian $(lsb_release -cs) stable"
+  echo "deb [arch=amd64] https://download.docker.com/linux/debian bullseye stable" > /etc/apt/sources.list.d/docker.list
   apt-get update
   ${apt_get} install containerd.io
-
   apt_clean

Review comment:
       Hi @rohityadavcloud @Pearl1594 the script fails for me on Ubuntu 20.04 at this line:
   
   ````
   /scripts/install_systemvm_packages.sh: line 96: apt_clean: command not found
   + fail 'install_systemvm_packages.sh failed'
   + clean_env
   + '[' /tmp/tmp.x7wCjvUAzz '!=' '' ']'
   + chroot /tmp/tmp.x7wCjvUAzz umount /proc /sys /dev /boot
   + '[' /tmp/tmp.x7wCjvUAzz '!=' '' ']'
   + umount /tmp/tmp.x7wCjvUAzz
   + sync
   + '[' /dev/nbd0 '!=' '' ']'
   + qemu-nbd -d /dev/nbd0
   /dev/nbd0 disconnected
   + sync
   + '[' /tmp/tmp.x7wCjvUAzz '!=' '' ']'
   + rm -fr /tmp/tmp.x7wCjvUAzz
   + echo 'Failed: install_systemvm_packages.sh failed'
   Failed: install_systemvm_packages.sh failed
   + exit 1
   ````




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org