[GitHub] [spark] LuciferYang commented on a diff in pull request #40560: [SPARK-42930][CORE][SQL] Change the access scope of `ProtobufSerDe` related implementations to `private[spark]`

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40560:
URL: https://github.com/apache/spark/pull/40560#discussion_r1148885810


##########
core/src/main/scala/org/apache/spark/status/protobuf/AccumulableInfoSerializer.scala:
##########
@@ -25,7 +25,7 @@ import org.apache.spark.status.api.v1.AccumulableInfo
 import org.apache.spark.status.protobuf.Utils.{getOptional, getStringField, setStringField}
 import org.apache.spark.util.Utils.weakIntern
 
-private[protobuf] object AccumulableInfoSerializer {
+private[spark] object AccumulableInfoSerializer {

Review Comment:
   cc @gengliangwang @dongjoon-hyun FYI
   
   Do you prefer `private[spark]` or  `private[protobuf]`?
   
   https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/protobuf/ProtobufSerDe.scala
   
   Should `ProtobufSerDe`  also be changed to `private[spark]`? Although it has been identified as `@DeveloperApi`
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org