You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/06/20 19:22:43 UTC
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/703
Jsgui tweaks
* config+sensors tooltip renders nicely
* catalog items listed in accordion view don't wrap
* yaml preview window focuses at the top not the bottom (for long blueprints)
The second one needs tested on windows to ensure scrollbars don't clutter.
You can test 2 and 3 with:
```
brooklyn.catalog:
items:
- id: foo-bar-baz-foo-bar-baz-foo-bar-baz-foo-bar-baz-foo-bar-baz-foo-bar-baz-foo-bar-baz_boo
itemType: template
item:
location: localhost
services:
- type: brooklyn.entity.basic.BasicEntity
brooklyn.config:
x:
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
blah
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn jsgui-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/703.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #703
----
commit 780f556740c070a214dbb169df2b89a1729b07d3
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-06-20T03:22:30Z
tidy jsgui for sensors+config
* word "copied" properly removed after delay
* use nice tooltip styling
* suppress tooltip if no useful info (ad hoc sensor/config)
commit d8a747360879db712bf0a9b19dc29f0a880a0b87
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-06-20T16:50:45Z
jsgui - don't wrap catalog items in accordion
commit cc3029fad3d09a9409031cb7d371cda7040ec8c4
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-06-20T17:13:28Z
in yaml preview window, scroll to top after setting contents
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r32920888
--- Diff: usage/jsgui/src/main/webapp/assets/tpl/apps/sensor-name.html ---
@@ -18,7 +18,17 @@
under the License.
-->
+<% if (description || type) { %>
<span class="sensor-name" rel="tooltip" data-placement="left"
- title="<% if (description) { %><b><%- description %></b><br/><% } %>(<%- type %>)">
+ title="<%
+ if (description) { %><b><%- description %></b><br/><% }
+ if (type) { %>(<%
+ if (type.startsWith("java.lang.") || type.startsWith("util.")) type = type.substring(10);
--- End diff --
As before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-113934455
Yes, I'd like this in 0.7.0, it fixes several glitches in the GUI.
And I have one more on catalog / user-start experience which will come later today which I'd love to get in. Unfortunately that one isn't such a small one. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r32920832
--- Diff: usage/jsgui/src/main/webapp/assets/tpl/apps/config-name.html ---
@@ -18,7 +18,17 @@
under the License.
-->
+<% if (description || type) { %>
<span class="config-name" rel="tooltip" data-placement="left"
- title="<% if (description) { %><b><%- description %></b><br/><% } %>(<%- type %>)">
+ title="<%
+ if (description) { %><b><%- description %></b><br/><% }
+ if (type) { %>(<%
+ if (type.startsWith("java.lang.") || type.startsWith("util.")) type = type.substring(10);
--- End diff --
Why `substring(10)` if `type.startsWith("util.")`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r33016300
--- Diff: usage/jsgui/src/main/webapp/assets/css/base.css ---
@@ -1114,6 +1114,11 @@ tr.app-add-wizard-config-entry {
margin-bottom: 6px;
background-color: #F0F0F0;
border-radius: 5px;
+ overflow-y: scroll;
--- End diff --
This causes the vertical scrollbar on Windows. It's on the element that contains all accordion elements. Looks like it's not really needed? It's not visible on OS X due to the transparent scrollbars.
Not important of course, can be merged as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-114195416
@neykov thanks for the screen shot -- i'd rather the scrollbar wasn't there but i think worst case we can live with it; wdyt?
the only CSS rule intro'd here applies to the individual rows -- and on mac the vert scroll bar is per "accordion-item" (e.g. applications, or entities; but not all for) -- so i'm wondering if that is introduced here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r33122646
--- Diff: usage/jsgui/src/main/webapp/assets/css/base.css ---
@@ -1114,6 +1114,11 @@ tr.app-add-wizard-config-entry {
margin-bottom: 6px;
background-color: #F0F0F0;
border-radius: 5px;
+ overflow-y: scroll;
--- End diff --
Why the hell did I add this?!?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r32961669
--- Diff: usage/jsgui/src/main/webapp/assets/tpl/apps/config-name.html ---
@@ -18,7 +18,17 @@
under the License.
-->
+<% if (description || type) { %>
<span class="config-name" rel="tooltip" data-placement="left"
- title="<% if (description) { %><b><%- description %></b><br/><% } %>(<%- type %>)">
+ title="<%
+ if (description) { %><b><%- description %></b><br/><% }
+ if (type) { %>(<%
+ if (type.startsWith("java.lang.") || type.startsWith("util.")) type = type.substring(10);
--- End diff --
good spot. should be `java.util.` of course!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-113882237
@sjcorbett could you review this please?
@ahgittin asfbot failure is unrelated - fixed in #702, introduced in #700
@ahgittin do you want this merged for 0.7.0 release, or can it be deferred?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-114195972
@sjcorbett fix pushed for the `util.` issue (in two places)
good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-114197140
Fire away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#issuecomment-114070472
Horizontal scroll looks fine on Windows:
There's a vertical scrollbar though, caused by a `scrollbar-y: scroll` rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Jsgui tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/703#discussion_r33123848
--- Diff: usage/jsgui/src/main/webapp/assets/css/base.css ---
@@ -1114,6 +1114,11 @@ tr.app-add-wizard-config-entry {
margin-bottom: 6px;
background-color: #F0F0F0;
border-radius: 5px;
+ overflow-y: scroll;
--- End diff --
I'm gonna sneak a remove in to master directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---