You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 04:49:04 UTC
[GitHub] [pulsar] dragonls opened a new pull request, #17992: [improve][broker] Add test case for system topic schema not compatible bug.
dragonls opened a new pull request, #17992:
URL: https://github.com/apache/pulsar/pull/17992
Master Issue: #17979
Related to #17986
### Motivation
Add test case to cover system topic schema compatibility.
### Modifications
Add test case (`org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest#testSystemTopicSchemaCompatibility`) to cover system topic schema compatibility.
The `schemaCompatibilityStrategy` of system topic should always be the same as the conf `systemTopicSchemaCompatibilityStrategy`, which is default `SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE`.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- `org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest#testSystemTopicSchemaCompatibility`
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/dragonls/pulsar/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #17992:
URL: https://github.com/apache/pulsar/pull/17992#issuecomment-1275536962
@dragonls I think it should also cherry-pick to branch-2.11 and branch-2.9 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
URL: https://github.com/apache/pulsar/pull/17992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dragonls commented on pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
Posted by GitBox <gi...@apache.org>.
dragonls commented on PR #17992:
URL: https://github.com/apache/pulsar/pull/17992#issuecomment-1275571911
> @dragonls I think it should also cherry-pick to branch-2.11 and branch-2.9 right?
branch-2.11 is ok，but branch-2.9 is no need because #17986 has covered this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17992:
URL: https://github.com/apache/pulsar/pull/17992#issuecomment-1277027509
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/17992?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@51be6cd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/17992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17992 +/- ##
=========================================
Coverage ? 70.74%
Complexity ? 437
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1589
Misses ? 484
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.74% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17992:
URL: https://github.com/apache/pulsar/pull/17992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org