You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/10/20 07:33:24 UTC
[GitHub] [dubbo] guohao commented on a diff in pull request #10761: triple support upper header key
guohao commented on code in PR #10761:
URL: https://github.com/apache/dubbo/pull/10761#discussion_r1000248010
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/StreamUtils.java:
##########
@@ -89,9 +95,23 @@ public static void convertAttachment(DefaultHttp2Headers headers,
if (TripleHeaderEnum.containsExcludeAttachments(key)) {
continue;
}
+ if (!entry.getKey().equals(key)) {
Review Comment:
```java
if(needConvertHeaderKey)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org