You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/01/16 21:16:15 UTC
Review Request 16984: Get rid of ambiguities about exactly what object is
being used to send calls to the scheduler. (See AURORA-42).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/
-----------------------------------------------------------
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description
-------
Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
Also do some cleanups of sloppy stuff in tests.
Diffs
-----
src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0
src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
Diff: https://reviews.apache.org/r/16984/diff/
Testing
-------
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
=========================== 3 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.19 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 0.53 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 26 items
src/test/python/apache/aurora/client/api/test_updater.py ..........................
========================== 26 passed in 0.36 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 17 items
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_status.py .....
src/test/python/apache/aurora/client/cli/test_diff.py ...
========================== 17 passed in 0.48 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 24 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ...
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 24 passed in 0.78 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.17 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_aurora_job_key.py .
=========================== 1 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_cluster.py .
=========================== 1 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/common/test_clusters.py ....
=========================== 4 passed in 0.08 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/common/test_cluster_option.py ..
=========================== 2 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/common/test_http_signaler.py ...
=========================== 3 passed in 0.05 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 7 items
src/test/python/apache/aurora/config/test_base.py .......
=========================== 7 passed in 0.70 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/config/test_constraint_parsing.py .
=========================== 1 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/config/test_loader.py ......
=========================== 6 passed in 0.11 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 10 items
src/test/python/apache/aurora/config/test_thrift.py ..........
========================== 10 passed in 0.87 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_detector.py ....
=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_vars.py ....
=========================== 4 passed in 0.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 5 items
src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
========================== 5 passed in 16.81 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
=========================== 2 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/executor/common/test_health_checker.py ...
=========================== 3 passed in 1.33 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_status_checker.py .
=========================== 1 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_task_info.py .
=========================== 1 passed in 0.13 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 16984: Get rid of ambiguities about exactly what object
is being used to send calls to the scheduler. (See AURORA-42).
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/#review32070
-----------------------------------------------------------
Can you put the ticket (AURORA-42) in the bug field, and link to this review from the ticket?
- Bill Farner
On Jan. 16, 2014, 8:16 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 8:16 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
>
> Also do some cleanups of sloppy stuff in tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
> src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
> src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
> src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
> src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
> src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
> src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
> src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
> src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0
> src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
> src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
> src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
> src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
> src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
> src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
> src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
> src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
> src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
> src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
> src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
> src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
>
> Diff: https://reviews.apache.org/r/16984/diff/
>
>
> Testing
> -------
>
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
>
> =========================== 3 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.19 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 0.53 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 26 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ..........................
>
> ========================== 26 passed in 0.36 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 17 items
>
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
>
> ========================== 17 passed in 0.48 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 24 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ...
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 24 passed in 0.78 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.17 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_aurora_job_key.py .
>
> =========================== 1 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_cluster.py .
>
> =========================== 1 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/common/test_clusters.py ....
>
> =========================== 4 passed in 0.08 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/common/test_cluster_option.py ..
>
> =========================== 2 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/common/test_http_signaler.py ...
>
> =========================== 3 passed in 0.05 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 7 items
>
> src/test/python/apache/aurora/config/test_base.py .......
>
> =========================== 7 passed in 0.70 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/config/test_constraint_parsing.py .
>
> =========================== 1 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/config/test_loader.py ......
>
> =========================== 6 passed in 0.11 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 10 items
>
> src/test/python/apache/aurora/config/test_thrift.py ..........
>
> ========================== 10 passed in 0.87 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_detector.py ....
>
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_vars.py ....
>
> =========================== 4 passed in 0.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 5 items
>
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
>
> ========================== 5 passed in 16.81 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
>
> =========================== 2 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py ...
>
> =========================== 3 passed in 1.33 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_status_checker.py .
>
> =========================== 1 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_task_info.py .
>
> =========================== 1 passed in 0.13 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
> src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
> src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
> src.test.python.apache.aurora.config.test_base ..... SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
> src.test.python.apache.aurora.config.test_loader ..... SUCCESS
> src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16984: Get rid of ambiguities about exactly what object
is being used to send calls to the scheduler. (See AURORA-42).
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/
-----------------------------------------------------------
(Updated Jan. 17, 2014, 2:30 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Fix merge issues against master, so that the patch can be applied and change can be pushed.
Bugs: aurora-42
https://issues.apache.org/jira/browse/aurora-42
Repository: aurora
Description
-------
Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
Also do some cleanups of sloppy stuff in tests.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
src/test/python/apache/aurora/client/cli/test_status.py 05f3929507b4e527330d628e60a8c5d5fff80fae
src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
Diff: https://reviews.apache.org/r/16984/diff/
Testing
-------
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
=========================== 3 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.19 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 0.53 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 26 items
src/test/python/apache/aurora/client/api/test_updater.py ..........................
========================== 26 passed in 0.36 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 17 items
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_status.py .....
src/test/python/apache/aurora/client/cli/test_diff.py ...
========================== 17 passed in 0.48 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 24 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ...
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 24 passed in 0.78 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.17 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_aurora_job_key.py .
=========================== 1 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_cluster.py .
=========================== 1 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/common/test_clusters.py ....
=========================== 4 passed in 0.08 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/common/test_cluster_option.py ..
=========================== 2 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/common/test_http_signaler.py ...
=========================== 3 passed in 0.05 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 7 items
src/test/python/apache/aurora/config/test_base.py .......
=========================== 7 passed in 0.70 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/config/test_constraint_parsing.py .
=========================== 1 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/config/test_loader.py ......
=========================== 6 passed in 0.11 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 10 items
src/test/python/apache/aurora/config/test_thrift.py ..........
========================== 10 passed in 0.87 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_detector.py ....
=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_vars.py ....
=========================== 4 passed in 0.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 5 items
src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
========================== 5 passed in 16.81 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
=========================== 2 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/executor/common/test_health_checker.py ...
=========================== 3 passed in 1.33 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_status_checker.py .
=========================== 1 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_task_info.py .
=========================== 1 passed in 0.13 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 16984: Get rid of ambiguities about exactly what object
is being used to send calls to the scheduler. (See AURORA-42).
Posted by Jonathan Boulle <jo...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/#review32180
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Boulle
On Jan. 16, 2014, 8:48 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 8:48 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Bugs: aurora-42
> https://issues.apache.org/jira/browse/aurora-42
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
>
> Also do some cleanups of sloppy stuff in tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
> src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
> src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
> src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
> src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
> src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
> src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
> src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
> src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0
> src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
> src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
> src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
> src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
> src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
> src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
> src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
> src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
> src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
> src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
> src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
> src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
>
> Diff: https://reviews.apache.org/r/16984/diff/
>
>
> Testing
> -------
>
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
>
> =========================== 3 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.19 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 0.53 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 26 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ..........................
>
> ========================== 26 passed in 0.36 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 17 items
>
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
>
> ========================== 17 passed in 0.48 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 24 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ...
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 24 passed in 0.78 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.17 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_aurora_job_key.py .
>
> =========================== 1 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_cluster.py .
>
> =========================== 1 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/common/test_clusters.py ....
>
> =========================== 4 passed in 0.08 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/common/test_cluster_option.py ..
>
> =========================== 2 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/common/test_http_signaler.py ...
>
> =========================== 3 passed in 0.05 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 7 items
>
> src/test/python/apache/aurora/config/test_base.py .......
>
> =========================== 7 passed in 0.70 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/config/test_constraint_parsing.py .
>
> =========================== 1 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/config/test_loader.py ......
>
> =========================== 6 passed in 0.11 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 10 items
>
> src/test/python/apache/aurora/config/test_thrift.py ..........
>
> ========================== 10 passed in 0.87 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_detector.py ....
>
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_vars.py ....
>
> =========================== 4 passed in 0.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 5 items
>
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
>
> ========================== 5 passed in 16.81 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
>
> =========================== 2 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py ...
>
> =========================== 3 passed in 1.33 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_status_checker.py .
>
> =========================== 1 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_task_info.py .
>
> =========================== 1 passed in 0.13 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
> src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
> src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
> src.test.python.apache.aurora.config.test_base ..... SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
> src.test.python.apache.aurora.config.test_loader ..... SUCCESS
> src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16984: Get rid of ambiguities about exactly what object
is being used to send calls to the scheduler. (See AURORA-42).
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/#review32106
-----------------------------------------------------------
Ship it!
- Brian Wickman
On Jan. 16, 2014, 8:48 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 8:48 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Bugs: aurora-42
> https://issues.apache.org/jira/browse/aurora-42
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
>
> Also do some cleanups of sloppy stuff in tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
> src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
> src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
> src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
> src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
> src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
> src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
> src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
> src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0
> src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
> src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
> src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
> src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
> src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
> src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
> src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
> src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
> src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
> src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
> src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
> src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
>
> Diff: https://reviews.apache.org/r/16984/diff/
>
>
> Testing
> -------
>
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
>
> =========================== 3 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.19 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.18 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 0.53 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 26 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ..........................
>
> ========================== 26 passed in 0.36 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 17 items
>
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
>
> ========================== 17 passed in 0.48 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 24 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ...
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 24 passed in 0.78 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.22 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.17 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.16 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_aurora_job_key.py .
>
> =========================== 1 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/common/test_cluster.py .
>
> =========================== 1 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/common/test_clusters.py ....
>
> =========================== 4 passed in 0.08 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/common/test_cluster_option.py ..
>
> =========================== 2 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/common/test_http_signaler.py ...
>
> =========================== 3 passed in 0.05 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 7 items
>
> src/test/python/apache/aurora/config/test_base.py .......
>
> =========================== 7 passed in 0.70 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/config/test_constraint_parsing.py .
>
> =========================== 1 passed in 0.06 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 6 items
>
> src/test/python/apache/aurora/config/test_loader.py ......
>
> =========================== 6 passed in 0.11 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 10 items
>
> src/test/python/apache/aurora/config/test_thrift.py ..........
>
> ========================== 10 passed in 0.87 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_detector.py ....
>
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 4 items
>
> src/test/python/apache/aurora/executor/test_executor_vars.py ....
>
> =========================== 4 passed in 0.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 5 items
>
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
>
> ========================== 5 passed in 16.81 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 2 items
>
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
>
> =========================== 2 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 3 items
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py ...
>
> =========================== 3 passed in 1.33 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_status_checker.py .
>
> =========================== 1 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- pytest-2.5.1
> collected 1 items
>
> src/test/python/apache/aurora/executor/common/test_task_info.py .
>
> =========================== 1 passed in 0.13 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
> src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
> src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
> src.test.python.apache.aurora.config.test_base ..... SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
> src.test.python.apache.aurora.config.test_loader ..... SUCCESS
> src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16984: Get rid of ambiguities about exactly what object
is being used to send calls to the scheduler. (See AURORA-42).
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16984/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 3:48 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Add bug link.
Bugs: aurora-42
https://issues.apache.org/jira/browse/aurora-42
Repository: aurora
Description
-------
Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).
Also do some cleanups of sloppy stuff in tests.
Diffs
-----
src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933
src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157
src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4
src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d
src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf
src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0
src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c
src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457
src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0
src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84
src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5
src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737
src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b
src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084
src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456
src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35
src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef
src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd
src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da
src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc
src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260
Diff: https://reviews.apache.org/r/16984/diff/
Testing
-------
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
=========================== 3 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.19 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.18 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 0.53 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 26 items
src/test/python/apache/aurora/client/api/test_updater.py ..........................
========================== 26 passed in 0.36 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 17 items
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_status.py .....
src/test/python/apache/aurora/client/cli/test_diff.py ...
========================== 17 passed in 0.48 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 24 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ...
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 24 passed in 0.78 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.17 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.16 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_aurora_job_key.py .
=========================== 1 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/common/test_cluster.py .
=========================== 1 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/common/test_clusters.py ....
=========================== 4 passed in 0.08 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/common/test_cluster_option.py ..
=========================== 2 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/common/test_http_signaler.py ...
=========================== 3 passed in 0.05 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 7 items
src/test/python/apache/aurora/config/test_base.py .......
=========================== 7 passed in 0.70 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/config/test_constraint_parsing.py .
=========================== 1 passed in 0.06 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/config/test_loader.py ......
=========================== 6 passed in 0.11 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 10 items
src/test/python/apache/aurora/config/test_thrift.py ..........
========================== 10 passed in 0.87 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_detector.py ....
=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/executor/test_executor_vars.py ....
=========================== 4 passed in 0.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 5 items
src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
========================== 5 passed in 16.81 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
=========================== 2 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 3 items
src/test/python/apache/aurora/executor/common/test_health_checker.py ...
=========================== 3 passed in 1.33 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_status_checker.py .
=========================== 1 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/executor/common/test_task_info.py .
=========================== 1 passed in 0.13 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
src.test.python.apache.aurora.admin.mesos_maintenance ..... SUCCESS
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Mark Chu-Carroll