[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8261: reuse regex matcher in dictionary based LIKE queries

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8261:
URL: https://github.com/apache/pinot/pull/8261#discussion_r816210733



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java
##########
@@ -64,6 +65,7 @@ public static BaseRawValueBasedPredicateEvaluator newRawValueBasedEvaluator(Rege
   private static final int PATTERN_FLAG = Pattern.UNICODE_CASE | Pattern.CASE_INSENSITIVE;
 
   private static final class DictionaryBasedRegexpLikePredicateEvaluator extends BaseDictionaryBasedPredicateEvaluator {
+    private final Matcher _matcher;

Review comment:
       Let's document the reason why we want to store the matcher? We can also remove the `_pattern`

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java
##########
@@ -64,6 +65,7 @@ public static BaseRawValueBasedPredicateEvaluator newRawValueBasedEvaluator(Rege
   private static final int PATTERN_FLAG = Pattern.UNICODE_CASE | Pattern.CASE_INSENSITIVE;
 
   private static final class DictionaryBasedRegexpLikePredicateEvaluator extends BaseDictionaryBasedPredicateEvaluator {
+    private final Matcher _matcher;

Review comment:
       (minor) Do not add `private` in a `private` inner class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org