You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Junichi Yamamoto <ju...@gmail.com> on 2017/11/25 04:07:02 UTC
Can pull requests be accepted without ICLA?
Hello,
Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
GitHub. Some authors may not sign ICLA. Can we merge them without
ICLA?
Thanks,
Junichi
Re: Can pull requests be accepted without ICLA?
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hey,
Am Samstag, den 25.11.2017, 12:21 +0100 schrieb Antonio:
> I would prefer so. Otherwise the contributions should be rejected, IMHO.
>
> The Apache OFBiz, for example, introduced this policy in 2014, as per [1].
>
> Signing the ICLA is very easy, and gives us the confidence that we won't
> be sued in the future because someone is claiming intellectual rights
> over the code.
>
> [1]
> https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Contributors
>
> El 25/11/17 a las 05:07, Junichi Yamamoto escribió:
> > Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
> > GitHub. Some authors may not sign ICLA. Can we merge them without
> > ICLA?
I would prefer a ICLA, but according to apache legal it is not strictly
required:
https://issues.apache.org/jira/browse/LEGAL-156
I'm a bit ambivalent about this. Requiring an ICLA will hinder "drive-
by" contributions, but it would make it easier/safer.
Given that we'll need contributors and contributors are the source for
committers, I'd tend not to require an ICLA at this point.
Greetings
Matthias
Re: Can pull requests be accepted without ICLA?
Posted by Antonio <an...@vieiro.net>.
I would prefer so. Otherwise the contributions should be rejected, IMHO.
The Apache OFBiz, for example, introduced this policy in 2014, as per [1].
Signing the ICLA is very easy, and gives us the confidence that we won't
be sued in the future because someone is claiming intellectual rights
over the code.
Just my 2 cents,
Antonio
[1]
https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Contributors
El 25/11/17 a las 05:07, Junichi Yamamoto escribió:
> Hello,
>
> Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
> GitHub. Some authors may not sign ICLA. Can we merge them without
> ICLA?
>
> Thanks,
> Junichi
>
Re: Can pull requests be accepted without ICLA?
Posted by Junichi Yamamoto <ju...@gmail.com>.
> by being too bureaucratic
I don't mean it at all, of course. I am just worried that problems
occur without the ICLA :)
Umm, it's very ambiguous... OK. I would not ask contributors anything
about the ICLA.
Thanks,
Junichi
2017-11-26 16:34 GMT+09:00 Emilian Bold <em...@protonmail.ch>:
> It's good to have an ICLA but we might miss valuable contributions by being too bureaucratic.
>
> In my view simple PRs don't need an ICLA. This include basic fixes, documentation tweaks, simple features, etc.
>
> Don't ask users to expressly send a signed scanned ICLA file. Remember to mention a PGP signed text file is just as acceptable by Apache and it's simple to produce by some users (for other, it might be harder)
>
> A serial contributor should be reminded to sign the ICLA.
>
> --emi
>
>
>>-------- Original Message --------
>>Subject: Re: Can pull requests be accepted without ICLA?
>>Local Time: November 26, 2017 5:20 AM
>>UTC Time: November 26, 2017 3:20 AM
>>From: junichi0206@gmail.com
>>To: NetBeans Dev@ <de...@netbeans.incubator.apache.org>
>>
>>Thanks a lot for your answers!
>>
>> It seems that iCLA is required in some projects (from Antonio's link).
>> However, it seems that we can merge PRs without ICLA(from Matthias and
>> Geertjan's comments).
>> I thought that contributors should sign an iCLA. Because I needed an
>> OCLA when I provided patches to (Oracle) NetBeans. But I was not sure
>> in Apache. So I asked this.
>> Some contributors might not sign the iCLA but I would suggest for
>> "First-time contributor" to sign it.
>>
>> Thanks,
>> Junichi
>>
>> 2017-11-25 22:15 GMT+09:00 Geertjan Wielenga geertjan.wielenga@googlemail.com:
>>>Yes. The merging of a PR must be done by a committer, i.e., someone with
>>> iCLA, etc, but a PR can be provided by anybody, with or without committer
>>> status.
>>>Gj
>>>On Sat, 25 Nov 2017 at 05:07, Junichi Yamamoto junichi0206@gmail.com
>>> wrote:
>>>>Hello,
>>>>Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
>>>> GitHub. Some authors may not sign ICLA. Can we merge them without
>>>> ICLA?
>>>>Thanks,
>>>> Junichi
Re: Can pull requests be accepted without ICLA?
Posted by Emilian Bold <em...@protonmail.ch>.
It's good to have an ICLA but we might miss valuable contributions by being too bureaucratic.
In my view simple PRs don't need an ICLA. This include basic fixes, documentation tweaks, simple features, etc.
Don't ask users to expressly send a signed scanned ICLA file. Remember to mention a PGP signed text file is just as acceptable by Apache and it's simple to produce by some users (for other, it might be harder)
A serial contributor should be reminded to sign the ICLA.
--emi
>-------- Original Message --------
>Subject: Re: Can pull requests be accepted without ICLA?
>Local Time: November 26, 2017 5:20 AM
>UTC Time: November 26, 2017 3:20 AM
>From: junichi0206@gmail.com
>To: NetBeans Dev@ <de...@netbeans.incubator.apache.org>
>
>Thanks a lot for your answers!
>
> It seems that iCLA is required in some projects (from Antonio's link).
> However, it seems that we can merge PRs without ICLA(from Matthias and
> Geertjan's comments).
> I thought that contributors should sign an iCLA. Because I needed an
> OCLA when I provided patches to (Oracle) NetBeans. But I was not sure
> in Apache. So I asked this.
> Some contributors might not sign the iCLA but I would suggest for
> "First-time contributor" to sign it.
>
> Thanks,
> Junichi
>
> 2017-11-25 22:15 GMT+09:00 Geertjan Wielenga geertjan.wielenga@googlemail.com:
>>Yes. The merging of a PR must be done by a committer, i.e., someone with
>> iCLA, etc, but a PR can be provided by anybody, with or without committer
>> status.
>>Gj
>>On Sat, 25 Nov 2017 at 05:07, Junichi Yamamoto junichi0206@gmail.com
>> wrote:
>>>Hello,
>>>Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
>>> GitHub. Some authors may not sign ICLA. Can we merge them without
>>> ICLA?
>>>Thanks,
>>> Junichi
Re: Can pull requests be accepted without ICLA?
Posted by Junichi Yamamoto <ju...@gmail.com>.
Thanks a lot for your answers!
It seems that iCLA is required in some projects (from Antonio's link).
However, it seems that we can merge PRs without ICLA(from Matthias and
Geertjan's comments).
I thought that contributors should sign an iCLA. Because I needed an
OCLA when I provided patches to (Oracle) NetBeans. But I was not sure
in Apache. So I asked this.
Some contributors might not sign the iCLA but I would suggest for
"First-time contributor" to sign it.
Thanks,
Junichi
2017-11-25 22:15 GMT+09:00 Geertjan Wielenga <ge...@googlemail.com>:
> Yes. The merging of a PR must be done by a committer, i.e., someone with
> iCLA, etc, but a PR can be provided by anybody, with or without committer
> status.
>
> Gj
>
> On Sat, 25 Nov 2017 at 05:07, Junichi Yamamoto <ju...@gmail.com>
> wrote:
>
>> Hello,
>>
>> Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
>> GitHub. Some authors may not sign ICLA. Can we merge them without
>> ICLA?
>>
>> Thanks,
>> Junichi
>>
Re: Can pull requests be accepted without ICLA?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Yes. The merging of a PR must be done by a committer, i.e., someone with
iCLA, etc, but a PR can be provided by anybody, with or without committer
status.
Gj
On Sat, 25 Nov 2017 at 05:07, Junichi Yamamoto <ju...@gmail.com>
wrote:
> Hello,
>
> Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in
> GitHub. Some authors may not sign ICLA. Can we merge them without
> ICLA?
>
> Thanks,
> Junichi
>