You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/10 16:18:26 UTC

Review Request 26555: Configs: no longer showing CS changes on compare

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26555/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-7725
    https://issues.apache.org/jira/browse/AMBARI-7725


Repository: ambari


Description
-------

1) Make a change to CapScheduler in yarn configs.
2) save change
3) perform compare between versions
CapScheduler changes no longer show in UI. This is a regression.


Diffs
-----

  ambari-web/app/utils/config.js 4b26608 

Diff: https://reviews.apache.org/r/26555/diff/


Testing
-------

 4548 tests complete (9 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 26555: Configs: no longer showing CS changes on compare

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26555/#review56139
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 10, 2014, 2:18 після полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26555/
> -----------------------------------------------------------
> 
> (Updated Жов. 10, 2014, 2:18 після полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7725
>     https://issues.apache.org/jira/browse/AMBARI-7725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Make a change to CapScheduler in yarn configs.
> 2) save change
> 3) perform compare between versions
> CapScheduler changes no longer show in UI. This is a regression.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/utils/config.js 4b26608 
> 
> Diff: https://reviews.apache.org/r/26555/diff/
> 
> 
> Testing
> -------
> 
>  4548 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Re: Review Request 26555: Configs: no longer showing CS changes on compare

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26555/#review56140
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 10, 2014, 2:18 p.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26555/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 2:18 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7725
>     https://issues.apache.org/jira/browse/AMBARI-7725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Make a change to CapScheduler in yarn configs.
> 2) save change
> 3) perform compare between versions
> CapScheduler changes no longer show in UI. This is a regression.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/utils/config.js 4b26608 
> 
> Diff: https://reviews.apache.org/r/26555/diff/
> 
> 
> Testing
> -------
> 
>  4548 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>