You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by he...@apache.org on 2020/09/01 03:45:49 UTC
[hadoop] branch trunk updated: HADOOP-17235. Erasure Coding: Remove
dead code from common side. Contributed by Fei Hui.
This is an automated email from the ASF dual-hosted git repository.
hexiaoqiao pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 7e671f3 HADOOP-17235. Erasure Coding: Remove dead code from common side. Contributed by Fei Hui.
7e671f3 is described below
commit 7e671f3b657fe5b8bd7a3946ee8e6b3f975564c5
Author: He Xiaoqiao <he...@apache.org>
AuthorDate: Tue Sep 1 11:35:55 2020 +0800
HADOOP-17235. Erasure Coding: Remove dead code from common side. Contributed by Fei Hui.
---
.../apache/hadoop/io/erasurecode/ECBlockGroup.java | 28 ----------------------
.../io/erasurecode/coder/ErasureDecoder.java | 23 ------------------
.../hadoop/io/erasurecode/TestCoderBase.java | 8 -------
3 files changed, 59 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECBlockGroup.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECBlockGroup.java
index c52d947..9dc3a3e 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECBlockGroup.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECBlockGroup.java
@@ -55,34 +55,6 @@ public class ECBlockGroup {
}
/**
- * Any erased data block?
- * @return true if any erased data block, false otherwise
- */
- public boolean anyErasedDataBlock() {
- for (int i = 0; i < dataBlocks.length; ++i) {
- if (dataBlocks[i].isErased()) {
- return true;
- }
- }
-
- return false;
- }
-
- /**
- * Any erased parity block?
- * @return true if any erased parity block, false otherwise
- */
- public boolean anyErasedParityBlock() {
- for (int i = 0; i < parityBlocks.length; ++i) {
- if (parityBlocks[i].isErased()) {
- return true;
- }
- }
-
- return false;
- }
-
- /**
* Get erased blocks count
* @return erased count of blocks
*/
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/coder/ErasureDecoder.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/coder/ErasureDecoder.java
index faf44d9..004fd38 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/coder/ErasureDecoder.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/coder/ErasureDecoder.java
@@ -172,27 +172,4 @@ public abstract class ErasureDecoder extends Configured
return erasedIndexes;
}
-
- /**
- * Get erased input blocks from inputBlocks
- * @param inputBlocks
- * @return an array of erased blocks from inputBlocks
- */
- protected ECBlock[] getErasedBlocks(ECBlock[] inputBlocks) {
- int numErased = getNumErasedBlocks(inputBlocks);
- if (numErased == 0) {
- return new ECBlock[0];
- }
-
- ECBlock[] erasedBlocks = new ECBlock[numErased];
- int i = 0, j = 0;
- for (; i < inputBlocks.length && j < erasedBlocks.length; i++) {
- if (inputBlocks[i].isErased()) {
- erasedBlocks[j++] = inputBlocks[i];
- }
- }
-
- return erasedBlocks;
- }
-
}
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/erasurecode/TestCoderBase.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/erasurecode/TestCoderBase.java
index 6d14de8..caab72c 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/erasurecode/TestCoderBase.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/erasurecode/TestCoderBase.java
@@ -66,10 +66,6 @@ public abstract class TestCoderBase {
protected boolean allowChangeInputs;
- protected int getChunkSize() {
- return chunkSize;
- }
-
protected void setChunkSize(int chunkSize) {
this.chunkSize = chunkSize;
this.zeroChunkBytes = new byte[chunkSize]; // With ZERO by default
@@ -90,10 +86,6 @@ public abstract class TestCoderBase {
}
}
- protected boolean isAllowDump() {
- return allowDump;
- }
-
/**
* Prepare before running the case.
* @param conf
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org