You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "SPRESENSE (via GitHub)" <gi...@apache.org> on 2023/09/14 02:27:42 UTC
[GitHub] [nuttx] SPRESENSE opened a new pull request, #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
SPRESENSE opened a new pull request, #10616:
URL: https://github.com/apache/nuttx/pull/10616
## Summary
Fix build error and warning when enable BOARD_USBDEV_SERIALSTR.
## Impact
drivers/usbdev
## Testing
on Spresense board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1326654270
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
here
https://github.com/apache/nuttx/blob/dfcf2dee293a7ac97d1a151ca82f3c802a7650ee/drivers/usbdev/composite.c#L393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1326684318
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
My meaning is this:
```suggestion
#define COMPOSITE_MANUFACTURERSTRID (1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1326697693
##########
drivers/usbdev/composite.c:
##########
@@ -38,6 +38,10 @@
#include <nuttx/usb/usbdev.h>
#include <nuttx/usb/usbdev_trace.h>
+#ifdef CONFIG_BOARD_USBDEV_SERIALSTR
+#include <nuttx/board.h>
Review Comment:
this line need intent too:
```suggestion
# include <nuttx/board.h>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325301800
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
I know, it is only use COMPOSITE_SERIALSTRID in composite.c actually, but they are the same string ID group defs, so I moved them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#issuecomment-1720387576
@xiaoxiang781216
I fix it. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325291190
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
these string is only used in drivers/usbdev/composite_desc.c, so don't need expose to public interface
##########
drivers/usbdev/composite.c:
##########
@@ -38,6 +38,10 @@
#include <nuttx/usb/usbdev.h>
#include <nuttx/usb/usbdev_trace.h>
+#ifdef CONFIG_BOARD_USBDEV_SERIALSTR
+#include <nuttx/board.h>
Review Comment:
could you point out where composite driver use the interface from nuttx/board.h?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325951591
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
let's algin with other line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#issuecomment-1720376945
@xiaoxiang781216
I fix it. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325300309
##########
drivers/usbdev/composite.c:
##########
@@ -38,6 +38,10 @@
#include <nuttx/usb/usbdev.h>
#include <nuttx/usb/usbdev_trace.h>
+#ifdef CONFIG_BOARD_USBDEV_SERIALSTR
+#include <nuttx/board.h>
Review Comment:
For calling `board_usbdev_serialstr()` at line 385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325951591
##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
#define COMPOSITE_CONFIGIDNONE (0) /* Config ID = 0 means to return to address mode */
#define COMPOSITE_CONFIGID (1) /* The only supported configuration ID */
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID (1)
Review Comment:
let's algin with other.lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10616:
URL: https://github.com/apache/nuttx/pull/10616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org