You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/04 02:00:23 UTC
[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
XuQianJin-Stars opened a new pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177
## What is the purpose of the pull request
Redo hudi-utilities log statements using SLF4J.
## Brief change log
Modify AnnotationLocation checkstyle rule in checkstyle.xml
## Verify this pull request
Use existing tests to verify the original module.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on issue #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#issuecomment-571154197
> Thanks for opening the PR @XuQianJin-Stars , only left some minor comments.
I addressed this commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363295383
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java
##########
@@ -110,7 +110,7 @@ public int compact(JavaSparkContext jsc, int retry) {
}
} while (ret != 0 && retry-- > 0);
} catch (Throwable t) {
- LOG.error(t);
+ LOG.error("The compact err:", t);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363297575
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/perf/TimelineServerPerf.java
##########
@@ -73,7 +73,8 @@ public TimelineServerPerf(Config cfg) throws IOException {
private void setHostAddrFromSparkConf(SparkConf sparkConf) {
String hostAddr = sparkConf.get("spark.driver.host", null);
if (hostAddr != null) {
- LOG.info("Overriding hostIp to (" + hostAddr + ") found in spark-conf. It was " + this.hostAddr);
+ LOG.info(
+ "Overriding hostIp to ({}) found in spark-conf. It was {}", hostAddr, this.hostAddr);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363296071
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -300,8 +300,7 @@ private void refreshTimeline() throws IOException {
}
if (Objects.equals(checkpointStr, resumeCheckpointStr.orElse(null))) {
- LOG.info("No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=("
- + resumeCheckpointStr + "). New Checkpoint=(" + checkpointStr + ")");
+ LOG.info("No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=({}). New Checkpoint=({})",resumeCheckpointStr,checkpointStr);
Review comment:
add blank before `,` and coiuld start a new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363294505
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java
##########
@@ -114,7 +114,7 @@ public int dataImport(JavaSparkContext jsc, int retry) {
ret = dataImport(jsc);
} while (ret != 0 && retry-- > 0);
} catch (Throwable t) {
- LOG.error(t);
+ LOG.error("The dataImport err:", t);
Review comment:
err -> error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363297199
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -385,7 +385,8 @@ public DeltaSync getDeltaSync() {
boolean error = false;
if (cfg.isAsyncCompactionEnabled()) {
// set Scheduler Pool.
- LOG.info("Setting Spark Pool name for delta-sync to " + SchedulerConfGenerator.DELTASYNC_POOL_NAME);
+ LOG.info("Setting Spark Pool name for delta-sync to {}",
+ SchedulerConfGenerator.DELTASYNC_POOL_NAME);
Review comment:
could be in one line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363296071
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -300,8 +300,7 @@ private void refreshTimeline() throws IOException {
}
if (Objects.equals(checkpointStr, resumeCheckpointStr.orElse(null))) {
- LOG.info("No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=("
- + resumeCheckpointStr + "). New Checkpoint=(" + checkpointStr + ")");
+ LOG.info("No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=({}). New Checkpoint=({})",resumeCheckpointStr,checkpointStr);
Review comment:
add blank before `,`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf merged pull request #1177: [HUDI-463] Redo
hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1177:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1177: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1177#discussion_r363297248
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -394,15 +395,16 @@ public DeltaSync getDeltaSync() {
long start = System.currentTimeMillis();
Option<String> scheduledCompactionInstant = deltaSync.syncOnce();
if (scheduledCompactionInstant.isPresent()) {
- LOG.info("Enqueuing new pending compaction instant (" + scheduledCompactionInstant + ")");
+ LOG.info("Enqueuing new pending compaction instant ({})",
+ scheduledCompactionInstant);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services